Repository navigation
Metrics of one dataset on the dataset; dactopus-ossie-clickhouse 0.10.1 - #39
Merged
Merged
Conversation
A metric that reads one dataset moves to that dataset's metrics (the Ossie spec's "Metric Scoping", apache/ossie#591) and a question names it dataset.metric. The five commerce metrics that read order lines or refunds with orders.in_sales_reports stay on the model. Metrics named like a field of their dataset or like a dataset are renamed: order_count, discount_amount, shipping_amount, tax_amount, refund_count, session_count, page_view_count, purchase_count, event_count. Descriptions name metrics as dataset.metric. A count of a dataset's rows is COUNT(*) where it counted a key that is never NULL. The SQL of every check_numbers question is the same up to these names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The changes stay under Unreleased: package versions, the README's revision and the changelog go back to 0.6.0 until the release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datasets[].metrics(Ossie spec, "Metric Scoping", feat(core-spec): support dataset-scoped metrics apache/ossie#591) and is asked for asdataset.metric. The five commerce metrics that read order lines or refunds withorders.in_sales_reportsstay on the model.order_count,discount_amount,shipping_amount,tax_amount,refund_count,session_count,page_view_count,purchase_count,event_count. The changelog has the full table of old and new names.dataset.metric; the README, the docs page and AGENTS.md follow.refunds.refunded_amount, now gets the metrics that add it up (A field asked for as a metric gets suggestions by spelling, and search can cut off the metrics dactopus-ossie-clickhouse#66).Checked with dactopus-ossie-clickhouse 0.10.0, and in CI with 0.10.1:
check_numbersquestions is the same as onmainup to the names; 23 count a dataset's rows withCOUNT(*)where they counted a key that is never NULL.check_numbers67 of 67,validate --urlpasses for each model.serve) gave the same numbers as hand-written ClickHouse queries for counts, monthly sales, refunds by month, conversion rate, GA4 revenue by currency and silent devices.Known: apache/ossie's reference validator (
validation/validate.pyonmain) reportsdevices.minutes_since_last_contactas referencing an undeclared fieldMINUTE. Its default sqlglot dialect reads the spec'sDATEDIFF(part, start, end)with the date part as a column. The expression follows the spec and the executor accepts it; the fix belongs in the validator.🤖 Generated with Claude Code