Skip to content

feat: update certificate generation process to improve user experienc… - #27

Merged
Daddyjohn63 merged 1 commit into
mainfrom
cert-timing
Aug 3, 2026
Merged

feat: update certificate generation process to improve user experienc…#27
Daddyjohn63 merged 1 commit into
mainfrom
cert-timing

Conversation

@Daddyjohn63

@Daddyjohn63 Daddyjohn63 commented Aug 3, 2026

Copy link
Copy Markdown
Owner

…e and sharing functionality

  • Adjusted the flow for first-time certificate generation to store the PDF and mark the ceremony complete before revealing share and download options.
  • Updated UI text to reflect changes in the download process.
  • Clarified backend logic to ensure ceremony completion is marked after PDF generation and storage.

Summary by CodeRabbit

  • New Features

    • Certificate generation now stores the PDF and completes the ceremony before downloading.
    • Completed ceremonies can download the certificate directly without repeating the upload or completion process.
  • Documentation

    • Updated certificate-page messaging and completion guidance to reflect the new workflow.

…e and sharing functionality

- Adjusted the flow for first-time certificate generation to store the PDF and mark the ceremony complete before revealing share and download options.
- Updated UI text to reflect changes in the download process.
- Clarified backend logic to ensure ceremony completion is marked after PDF generation and storage.
@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
naming-application-web Building Building Preview Aug 3, 2026 12:50pm

Request Review

@Daddyjohn63
Daddyjohn63 merged commit 934bacd into main Aug 3, 2026
1 of 3 checks passed
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cc369417-2346-45f0-acca-f391eb691f4f

📥 Commits

Reviewing files that changed from the base of the PR and between bd3e9fd and c4e9392.

📒 Files selected for processing (4)
  • apps/web/modules/ceremony/lib/use-certificate-download.ts
  • apps/web/modules/ceremony/ui/views/cat-certificate-view.tsx
  • apps/web/next-env.d.ts
  • packages/backend/convex/certificate.ts

📝 Walkthrough

Walkthrough

The certificate flow now uploads and stores the PDF, completes the ceremony, and then exposes download options on first generation. Completed ceremonies save the PDF locally. Related UI and backend documentation reflects this order.

Changes

Certificate flow

Layer / File(s) Summary
PDF generation and ceremony completion
apps/web/modules/ceremony/lib/use-certificate-download.ts, apps/web/modules/ceremony/ui/views/cat-certificate-view.tsx, packages/backend/convex/certificate.ts
First generation uploads the PDF and completes the ceremony before exposing download options. Completed ceremonies only save the PDF locally. UI and backend documentation reflects the updated flow.
Development route type wiring
apps/web/next-env.d.ts
The route type declaration import uses the development-specific generated path.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant useCertificateDownload
  participant Storage
  participant completeCeremony
  User->>useCertificateDownload: Generate certificate
  useCertificateDownload->>Storage: Upload generated PDF
  useCertificateDownload->>completeCeremony: Complete ceremony
  completeCeremony-->>useCertificateDownload: Completion result
  useCertificateDownload-->>User: Expose download options
Loading

Possibly related PRs

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cert-timing

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/backend/convex/certificate.ts

Parsing error: The keyword 'import' is reserved


Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant