Skip to content

fix: improve parsing quoted ACL usernames at end of input#141

Merged
DanCardin merged 1 commit into
DanCardin:mainfrom
Waszker:fix/acl-quoted-username-at-end
Jun 8, 2026
Merged

fix: improve parsing quoted ACL usernames at end of input#141
DanCardin merged 1 commit into
DanCardin:mainfrom
Waszker:fix/acl-quoted-username-at-end

Conversation

@Waszker

@Waszker Waszker commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Closes #140

@DanCardin DanCardin force-pushed the fix/acl-quoted-username-at-end branch from 47e8042 to e87d60f Compare June 8, 2026 14:50
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.85%. Comparing base (337665b) to head (e87d60f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #141   +/-   ##
=======================================
  Coverage   89.84%   89.85%           
=======================================
  Files          86       86           
  Lines        4118     4120    +2     
  Branches      858      859    +1     
=======================================
+ Hits         3700     3702    +2     
  Misses        338      338           
  Partials       80       80           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Waszker

Waszker commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

@DanCardin the CI failed with Error: The version '3.8' with architecture 'x64' was not found for Ubuntu 24.04. which looks like some sort of a flake. Could you try and rerun the failed job?

@DanCardin

Copy link
Copy Markdown
Owner

Thanks for the PRs!

@DanCardin DanCardin merged commit f3d214e into DanCardin:main Jun 8, 2026
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_acl_username rejects a quoted role name at the end of an ACL string

2 participants