Skip to content

CI: Run tests on arm too #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielEScherzer merged 4 commits into from
Oct 26, 2026
Merged

CI: Run tests on arm too #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a2a342
CI: Run tests on arm too
DanielEScherzer Oct 26, 2026
7f8a583
Ubuntu 24.04, show OS in name
DanielEScherzer Oct 26, 2026
a123324
Blocklist simd
DanielEScherzer Oct 26, 2026
0ce699f
Try to exclude reexport.c
DanielEScherzer Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,16 @@ jobs:
Run clippy (${{ matrix.php }},
php ${{ matrix.php_debug && 'debug' || 'release' }},
${{ matrix.php_zts && 'ZTS' || 'NTS' }},
rust ${{ matrix.rust }})
runs-on: ubuntu-latest
rust ${{ matrix.rust }} on ${{ matrix.os }})
strategy:
fail-fast: false
matrix:
php: ["PHP-8.5"]
rust: ["1.99.0"]
php_zts: [true, false]
php_debug: [true, false]
os: ["ubuntu-24.04", "ubuntu-24.04-arm"]
runs-on: ${{ matrix.os }}
steps:
# We need to clone and configure PHP so that bindings can be generated
# in the build script for clippy; need to build it so that php-config
Expand Down Expand Up @@ -94,22 +95,25 @@ jobs:
uses: ./php/php-src/ext/rust-ext/.github/actions/verify-generated
with:
working-directory: php/php-src/ext/rust-ext
extra-pathspec: ':(exclude)crates/sys/bindings.rs'
extra-pathspec: >
':(exclude)crates/sys/bindings.rs'
':(exclude)crates/sys/reexport.c'

test:
name: >
Run tests (${{ matrix.php }},
php ${{ matrix.php_debug && 'debug' || 'release' }},
${{ matrix.php_zts && 'ZTS' || 'NTS' }},
rust ${{ matrix.rust }})
runs-on: ubuntu-latest
rust ${{ matrix.rust }} on ${{ matrix.os }})
strategy:
fail-fast: false
matrix:
php: ["PHP-8.5"]
rust: ["1.99.0"]
php_zts: [true, false]
php_debug: [true, false]
os: ["ubuntu-24.04", "ubuntu-24.04-arm"]
runs-on: ${{ matrix.os }}
steps:
- name: Checkout PHP
uses: actions/checkout@v7
Expand Down
17 changes: 17 additions & 0 deletions crates/sys/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,23 @@ fn main() {
// type which is only declared in a C file. Also cannot manually reexport
// so just block it entirely
.blocklist_function("zend_lazy_object_get_instance")
// __m128i isn't FFI safe in zend_simd.h and those functions cannot be
// marked with target_feature, rust-lang/rust-bindgen#3533
.blocklist_function("_mm_sll_epi16")
.blocklist_function("_mm_sll_epi32")
.blocklist_function("_mm_sll_epi64")
.blocklist_function("_mm_sra_epi16")
.blocklist_function("_mm_sra_epi32")
.blocklist_function("_mm_srl_epi16")
.blocklist_function("_mm_srl_epi32")
.blocklist_function("_mm_srl_epi64")
.blocklist_function("_mm_madd_epi16")
.blocklist_function("_mm_mulhi_epi16")
.blocklist_function("_mm_mulhi_epu16")
.blocklist_function("_mm_mullo_epi16")
.blocklist_function("_mm_mul_epu32")
.blocklist_function("_mm_sad_epu8")
.blocklist_function("_mm_movemask_epi8")
.default_enum_style(EnumVariation::ModuleConsts)
.merge_extern_blocks(true)
// SLOW and didn't actually add anything
Expand Down
Loading