Skip to content

Update GitHub Actions workflow for tests - #149

Merged
Dargon789 merged 1 commit into
masterfrom
Dargon789-patch-2
Dec 26, 2025
Merged

Update GitHub Actions workflow for tests#149
Dargon789 merged 1 commit into
masterfrom
Dargon789-patch-2

Conversation

@Dargon789

@Dargon789 Dargon789 commented Dec 26, 2025

Copy link
Copy Markdown
Owner

Summary by Sourcery

Adjust the tests GitHub Actions workflow to streamline dependency installation and test execution configuration.

CI:

  • Remove redundant pnpm install step from the install job in the tests workflow.
  • Change the tests job dependency from the build job to the install job to align with the desired execution order.
  • Update the Foundry toolchain used in tests to track the nightly version.
  • Remove the explicit pnpm build step from the tests job so it only runs the test suite.

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@codesandbox

ghost commented Dec 26, 2025

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@bolt-new-by-stackblitz

ghost commented Dec 26, 2025

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel

ghost commented Dec 26, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
sequence-js-web Ready Ready Preview, Comment Dec 26, 2025 7:02pm
sequence.js Ready Ready Preview, Comment Dec 26, 2025 7:02pm
wagmi-project Ready Ready Preview, Comment Dec 26, 2025 7:02pm

@gemini-code-assist

ghost commented Dec 26, 2025

Copy link
Copy Markdown

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@sourcery-ai

ghost commented Dec 26, 2025

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the GitHub Actions test workflow to rely on the shared install job, stop re-running installs/builds redundantly, and move Foundry to the nightly toolchain for tests.

File-Level Changes

Change Details Files
Streamline dependency installation and remove redundant pnpm commands in CI jobs.
  • Drop the extra pnpm install --no-frozen-lockfile step from the install job, relying on the shared .github/actions/install-dependencies composite action for dependency setup.
  • Remove the explicit pnpm build command from the tests job so tests no longer run a full build step inline.
.github/workflows/tests.yml
Adjust job dependencies and Foundry toolchain version for the tests workflow.
  • Change the tests job dependency from build to install so that tests start after dependencies are installed rather than after a build job.
  • Update the Foundry toolchain version used in tests from the pinned v1.5.0 release to the nightly channel to track the latest Foundry changes.
.github/workflows/tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io

ghost commented Dec 26, 2025

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Using version: nightly for the Foundry toolchain can introduce non-deterministic CI failures when nightly changes; consider pinning to a specific nightly or version range and updating explicitly when needed.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Using `version: nightly` for the Foundry toolchain can introduce non-deterministic CI failures when nightly changes; consider pinning to a specific nightly or version range and updating explicitly when needed.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Dargon789
Dargon789 merged commit 9779987 into master Dec 26, 2025
@Dargon789
Dargon789 deleted the Dargon789-patch-2 branch December 26, 2025 19:10
@github-project-automation github-project-automation Bot moved this from Todo to Done in web3-Defi-Gamefi Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

# Sequence diagram for triggering and executing the dist publishing workflow

1 participant