Conversation
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Reviewer's GuideRefactors the GitHub Actions CI workflow by replacing the separate install job with an integrated test job that installs pnpm dependencies, starts a local anvil blockchain node, and runs tests, while simplifying build and tests jobs’ dependencies. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
left a comment
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
testjob YAML looks mis-indented (e.g.,stepsand the- name:entries are not aligned like in the other jobs), which will likely cause the workflow to be invalid—mirror the structure used in thebuild/testsjobs. - In the
Install pnpmstep you're using single&between commands instead of&&; this will background commands rather than failing fast on error—use&&to ensure setup stops on failures. - The
working-directory: ./correct-path-to-package-jsonvalue looks like a placeholder; set this to the actual path so dependency installation runs in the right project directory.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `test` job YAML looks mis-indented (e.g., `steps` and the `- name:` entries are not aligned like in the other jobs), which will likely cause the workflow to be invalid—mirror the structure used in the `build`/`tests` jobs.
- In the `Install pnpm` step you're using single `&` between commands instead of `&&`; this will background commands rather than failing fast on error—use `&&` to ensure setup stops on failures.
- The `working-directory: ./correct-path-to-package-json` value looks like a placeholder; set this to the actual path so dependency installation runs in the right project directory.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
da50474
0002c31
Summary by Sourcery
Update CI test workflow to use pnpm and a local forked blockchain node for running tests, and simplify job dependencies in the build and tests workflows.
CI: