Fix type change validation for hub import datasets without local files#657
Open
Irozuku wants to merge 1 commit into
Open
Fix type change validation for hub import datasets without local files#657Irozuku wants to merge 1 commit into
Irozuku wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeChangeValidatoralways attempted to POST the dataset file to/api/v1/dataset/validate_type_changes, but the hub import flow has no local file (the dataset is already stored on the server). This caused a422 Unprocessable Entityand locked the dialog with a failed validation state, making it impossible to change column types during a hub import preview.When
fileisnull, the component now skips the API call and immediately marks validation as passed, keeping the dialog open so the user can confirm the change normally.Type of Change
Check all that apply like this [x]:
Changes (by file)
DashAI/front/src/components/notebooks/datasetCreation/TypeChangeValidator.jsx: Skipvalidate_type_changesAPI call whenfileisnull; set result to{ valid: true }so the dialog opens in a confirmable state.Testing (optional)