Include translation function in model fetching dependencies#659
Open
Creylay wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Model names and descriptions in the Models module were not updating when the language was changed via the language selector. The component had to be reloaded for the correct language to appear. This happened because
fetchModelswas missingtin itsuseCallbackdependency array, so the API call was never re-triggered on language change. Addingtas a dependency causes a re-fetch whenever the language changes, returning the correct language from the backend via theAccept-Languageheader already set in the API interceptor.Type of Change
Changes (by file)
DashAI/front/src/components/models/ModelsRightBar.jsx: Addedtto theuseCallbackdependency array offetchModelsso the model list re-fetches when the language changes.Testing (optional)