👷 Allow passing a full commit hash to json-schemas --update#4784
Merged
Conversation
Bundles Sizes Evolution
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 15f8174 | Docs | Datadog PR Page | Give us feedback! |
bdibon
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When working with a specific commit from
rum-events-format(e.g. a commit that hasn't landed on any branch yet, or an exact reproducible reference), it was not possible to pass it directly tojson-schemas --update— only a branch name was accepted, which always resolved to the latest tip of that branch.Related PR: DataDog/rum-events-format#393
Changes
json-schemas --updatenow accepts either a branch name or a full 40-character commit hash. When a hash is detected, the GitHub API call is skipped and the hash is used directly.Test instructions
Run with a branch name to verify existing behaviour is unchanged:
Run with a full commit hash (grab one from
DataDog/rum-events-format) to verify it is used directly without an API call:Confirm
package.jsonis updated toDataDog/rum-events-format#commit=<that-hash>in both cases.Checklist