Skip to content

👷 Allow passing a full commit hash to json-schemas --update#4784

Merged
BenoitZugmeyer merged 1 commit into
mainfrom
benoit/json-schemas-commit-hash
Jun 15, 2026
Merged

👷 Allow passing a full commit hash to json-schemas --update#4784
BenoitZugmeyer merged 1 commit into
mainfrom
benoit/json-schemas-commit-hash

Conversation

@BenoitZugmeyer

@BenoitZugmeyer BenoitZugmeyer commented Jun 15, 2026

Copy link
Copy Markdown
Member

Motivation

When working with a specific commit from rum-events-format (e.g. a commit that hasn't landed on any branch yet, or an exact reproducible reference), it was not possible to pass it directly to json-schemas --update — only a branch name was accepted, which always resolved to the latest tip of that branch.

Related PR: DataDog/rum-events-format#393

Changes

  • json-schemas --update now accepts either a branch name or a full 40-character commit hash. When a hash is detected, the GitHub API call is skipped and the hash is used directly.

Test instructions

Run with a branch name to verify existing behaviour is unchanged:

node scripts/json-schemas.ts --update master

Run with a full commit hash (grab one from DataDog/rum-events-format) to verify it is used directly without an API call:

node scripts/json-schemas.ts --update <40-char-hash>

Confirm package.json is updated to DataDog/rum-events-format#commit=<that-hash> in both cases.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review June 15, 2026 14:58
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner June 15, 2026 14:58
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 172.04 KiB 172.04 KiB 0 B 0.00%
Rum Profiler 7.88 KiB 7.88 KiB 0 B 0.00%
Rum Recorder 21.09 KiB 21.09 KiB 0 B 0.00%
Logs 54.64 KiB 54.64 KiB 0 B 0.00%
Rum Slim 129.72 KiB 129.72 KiB 0 B 0.00%
Worker 22.96 KiB 22.96 KiB 0 B 0.00%

@datadog-prod-us1-3

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 76.81% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 15f8174 | Docs | Datadog PR Page | Give us feedback!

@BenoitZugmeyer BenoitZugmeyer merged commit 54fd886 into main Jun 15, 2026
32 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/json-schemas-commit-hash branch June 15, 2026 15:21
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants