👷 Improve checkTelemetryErrors: exclude deprecated datacenters and add detailed logging#4794
Merged
Merged
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: c3fa190 | Docs | Datadog PR Page | Give us feedback! |
thomas-lebeau
approved these changes
Jun 16, 2026
Bundles Sizes Evolution
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 529634f65e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When running the post-deploy telemetry error check, deprecated datacenters were included in the check, causing unnecessary noise or failures for sites that are no longer active. Additionally, when a check failed or was skipped, the error messages lacked enough context (site name, event counts, thresholds) to quickly diagnose the issue.
Changes
checkTelemetryErrors: log the datacenter list being checked, event counts vs. thresholds per query, and include site/query context in all error messagesErrorobjects with site and attempt context for clearer stack tracesTest instructions
Deploy a version and observe the telemetry check output — it should now log the list of datacenters being checked, and for each site/query pair, print the event count alongside the threshold.
Checklist