Skip to content

👷 Improve checkTelemetryErrors: exclude deprecated datacenters and add detailed logging#4794

Merged
BenoitZugmeyer merged 3 commits into
mainfrom
benoit/push-mkmkkqvuzlwt
Jun 16, 2026
Merged

👷 Improve checkTelemetryErrors: exclude deprecated datacenters and add detailed logging#4794
BenoitZugmeyer merged 3 commits into
mainfrom
benoit/push-mkmkkqvuzlwt

Conversation

@BenoitZugmeyer

Copy link
Copy Markdown
Member

Motivation

When running the post-deploy telemetry error check, deprecated datacenters were included in the check, causing unnecessary noise or failures for sites that are no longer active. Additionally, when a check failed or was skipped, the error messages lacked enough context (site name, event counts, thresholds) to quickly diagnose the issue.

Changes

  • Exclude deprecated datacenters from the runtime metadata selector used in the deploy check
  • Add detailed per-site logging to checkTelemetryErrors: log the datacenter list being checked, event counts vs. thresholds per query, and include site/query context in all error messages
  • Wrap network errors in structured Error objects with site and attempt context for clearer stack traces

Test instructions

Deploy a version and observe the telemetry check output — it should now log the list of datacenters being checked, and for each site/query pair, print the event count alongside the threshold.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Jun 16, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 76.81% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c3fa190 | Docs | Datadog PR Page | Give us feedback!

@BenoitZugmeyer BenoitZugmeyer changed the title 🔍 Improve checkTelemetryErrors: exclude deprecated datacenters and add detailed logging 👷 Improve checkTelemetryErrors: exclude deprecated datacenters and add detailed logging Jun 16, 2026
@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review June 16, 2026 08:55
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner June 16, 2026 08:55
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 172.04 KiB 172.04 KiB 0 B 0.00%
Rum Profiler 7.88 KiB 7.88 KiB 0 B 0.00%
Rum Recorder 21.09 KiB 21.09 KiB 0 B 0.00%
Logs 54.64 KiB 54.64 KiB 0 B 0.00%
Rum Slim 129.72 KiB 129.72 KiB 0 B 0.00%
Worker 22.96 KiB 22.96 KiB 0 B 0.00%

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 529634f65e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/deploy/lib/checkTelemetryErrors.ts
@BenoitZugmeyer BenoitZugmeyer merged commit 286a69c into main Jun 16, 2026
30 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/push-mkmkkqvuzlwt branch June 16, 2026 11:45
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants