[SVLS-8492] Fix permission error for durable forwarder publish job#337
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoJul 10, 2026
Conversation
…ase.sh The GitLab runner role for this project has no cloudformation:ValidateTemplate permission, so the publish job failed with AccessDenied. None of the other release.sh scripts in this repo call the CloudFormation API to validate; template correctness is already covered by cfn-lint on every push (.github/workflows/lint.yml). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
lym953
changed the title
There was a problem hiding this comment.
Pull request overview
Removes an AWS CloudFormation API validation step from the durable forwarder release script to prevent the GitLab release job from failing due to missing cloudformation:ValidateTemplate permissions.
Changes:
- Removed
aws cloudformation validate-templatefromaws_durable_function_event_forwarder/release.shto avoidAccessDeniedduring the manual publish job.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shreyamalpani
approved these changes
Jul 10, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
yiming.luo/fix-durable-forwarder-release-validate-permission
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
After merging #333, running the manual
publish durable function event forwarderjob failed:Job: https://gitlab.ddbuild.io/DataDog/cloudformation-template/-/jobs/1847411821
Fix
Drop the
aws cloudformation validate-templatecall fromrelease.sh. The GitLabrunner role for this project isn't granted
cloudformation:ValidateTemplate(that'san IAM change outside this repo), and this call isn't actually needed:
aws_quickstart, aws_llm, etc.) call the CloudFormation API to validate.
(
.github/workflows/lint.yml).Test plan
publish durable function event forwardermanual job onthe resulting master pipeline; confirm it uploads
v0.1.0.yamlandlatest.yamlto
s3://datadog-cloudformation-template/aws/lambda-durable-function-event-forwarder/.