Skip to content

[RUM] Clarify sample_rate rounding precision in retention filter spec #5067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
api-clients-generation-pipeline wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[RUM] Clarify sample_rate rounding precision in retention filter spec #5067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .generator/schemas/v2/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94282,7 +94282,7 @@ components:
example: true
type: boolean
trace_sample_rate:
description: The sample rate for the APM cross-product retention filter, between 0 and 100.
description: The sample rate for the APM cross-product retention filter, between 0 and 100. Values are rounded to two decimal places.
example: 25.0
format: double
maximum: 100
Expand All @@ -94297,7 +94297,7 @@ components:
example: true
type: boolean
trace_sample_rate:
description: The sample rate for the APM cross-product retention filter, between 0 and 100.
description: The sample rate for the APM cross-product retention filter, between 0 and 100. Values are rounded to two decimal places.
example: 25.0
format: double
maximum: 100
Expand All @@ -94314,7 +94314,7 @@ components:
example: true
type: boolean
trace_sample_rate:
description: The sample rate for the APM cross-product retention filter, between 0 and 100.
description: The sample rate for the APM cross-product retention filter, between 0 and 100. Values are rounded to two decimal places.
example: 25.0
format: double
maximum: 100
Expand Down Expand Up @@ -94933,7 +94933,7 @@ components:
$ref: '#/components/schemas/RumRetentionFilterData'
type: object
RumRetentionFilterSampleRate:
description: The sample rate for a RUM retention filter, between 0.1 and 100.
description: The sample rate for a RUM retention filter, between 0.1 and 100. Values are rounded to one decimal place on creation.
example: 50.5
format: double
maximum: 100
Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-api-client-v2/models/RumCrossProductSampling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export class RumCrossProductSampling {
*/
"traceEnabled"?: boolean;
/**
* The sample rate for the APM cross-product retention filter, between 0 and 100.
* The sample rate for the APM cross-product retention filter, between 0 and 100. Values are rounded to two decimal places.
*/
"traceSampleRate"?: number;

Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-api-client-v2/models/RumCrossProductSamplingCreate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export class RumCrossProductSamplingCreate {
*/
"traceEnabled"?: boolean;
/**
* The sample rate for the APM cross-product retention filter, between 0 and 100.
* The sample rate for the APM cross-product retention filter, between 0 and 100. Values are rounded to two decimal places.
*/
"traceSampleRate": number;

Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-api-client-v2/models/RumCrossProductSamplingUpdate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export class RumCrossProductSamplingUpdate {
*/
"traceEnabled"?: boolean;
/**
* The sample rate for the APM cross-product retention filter, between 0 and 100.
* The sample rate for the APM cross-product retention filter, between 0 and 100. Values are rounded to two decimal places.
*/
"traceSampleRate"?: number;

Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-api-client-v2/models/RumRetentionFilterAttributes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class RumRetentionFilterAttributes {
*/
"query"?: string;
/**
* The sample rate for a RUM retention filter, between 0.1 and 100.
* The sample rate for a RUM retention filter, between 0.1 and 100. Values are rounded to one decimal place on creation.
*/
"sampleRate"?: number;

Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-api-client-v2/models/RumRetentionFilterCreateAttributes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class RumRetentionFilterCreateAttributes {
*/
"query"?: string;
/**
* The sample rate for a RUM retention filter, between 0.1 and 100.
* The sample rate for a RUM retention filter, between 0.1 and 100. Values are rounded to one decimal place on creation.
*/
"sampleRate": number;

Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-api-client-v2/models/RumRetentionFilterUpdateAttributes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class RumRetentionFilterUpdateAttributes {
*/
"query"?: string;
/**
* The sample rate for a RUM retention filter, between 0.1 and 100.
* The sample rate for a RUM retention filter, between 0.1 and 100. Values are rounded to one decimal place on creation.
*/
"sampleRate"?: number;

Expand Down
Loading