feat(private-action-runner): add systemd host mounts - #3319
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 2d2491a | Docs | Datadog PR Page | Give us feedback! |
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a341af40a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f02f43c671
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
3 participants
What does this PR do?
Adds opt-in host systemd support to the node Private Action Runner. The cluster-agent runner is unchanged.
Configuration
Systemd access requires node PAR plus these annotations:
private-action-runner-systemd-journal-storageis required when systemd support is enabled and accepts:persistentfor/var/log/journalvolatilefor/run/log/journalbothfor both directoriesBoolean annotations accept only
"true"or"false". Invalid values or combinations are rejected before the node pod template is modified.Host mounts
/etc/machine-id/host/etc/machine-idFile/run/dbus/system_bus_socket/host/run/dbus/system_bus_socketSocket/run/systemd/journal/host/run/systemd/journalDirectory/var/log/journal/host/var/log/journalDirectorypersistentorboth/run/log/journal/host/run/log/journalDirectoryvolatileorbothSelected journal directories are read-only by default. Setting
private-action-runner-systemd-journal-vacuum-enabledto"true"makes only those directories writable so vacuum actions can delete archived journals. The existing/host/var/logmount remains read-only, and no broad/runmount is added.The journald runtime directory is mounted instead of the individual
io.systemd.journalsocket. This keeps a replacement socket visible inside the container when journald restarts or is upgraded.Motivation
DataDog/datadog-agent#54385 configures rshell systemd targets from paths under
/hostwhen PAR is containerized. The Operator must expose the corresponding host machine ID, system bus, journald runtime, and selected journal storage paths.