test(renderer): extend goldenImageTag pin to FIPS proxy - #3333
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intoAug 6, 2026
Merged
Conversation
Extend the pinning pattern PR #3234 introduced (goldenImageTag for NodeAgent and ClusterAgent) to the FIPS proxy sidecar tag. Without this, every FIPSProxyLatestVersion bump forces a regen of the suppression goldens even though the operator's rendering behaviour is unchanged. See the last such churn in PR bumping to 1.1.29.
jinh-labs
changed the title
|
🎯 Code Coverage (details) 🔗 Commit SHA: 0a52de0 | Docs | Datadog PR Page | Give us feedback! |
tbavelier
approved these changes
Aug 6, 2026
gh-worker-dd-mergequeue-cf854d
Bot
merged commit Aug 6, 2026
dbe4b70
into
main
70 of 73 checks passed
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
jinh-labs/pin-fips-tag-in-golden-tests
branch
August 6, 2026 15:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Pin the FIPS proxy tag in
TestRender_Goldenso FIPS version bumps stop churning the suppression goldens.Motivation
#3234 pinned the NodeAgent and ClusterAgent tags for this reason but missed the FIPS proxy tag. Every
FIPSProxyLatestVersionbump (most recently 1.1.28 → 1.1.29) currently forces a golden regen.Describe how you validated your changes
Regenerated goldens with
-update, then rerango test ./internal/controller/testutils/renderer/ -run TestRender_Goldenwithout-update— passes.