chore: add Datadog Code Coverage upload, remove CodeCov#3548
Draft
nikita-tkachenko-datadog wants to merge 3 commits into
Draft
chore: add Datadog Code Coverage upload, remove CodeCov#3548nikita-tkachenko-datadog wants to merge 3 commits into
nikita-tkachenko-datadog wants to merge 3 commits into
Conversation
Onboard dd-sdk-android to Datadog Code Coverage by wiring the existing datadog-ci coverage upload step in test:kover properly (add --service flag, export DATADOG_API_KEY, remove || true). Remove all CodeCov artifacts: the codecov.sh uploader script, .codecov.yml config, the CODECOV_TOKEN secret reference in vault_config.sh, and the bash codecov upload line from the kover CI job. Environment: Datadog workspace Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Remove invalid --service flag (not supported by datadog-ci coverage upload), remove redundant and unexported DATADOG_API_KEY assignment, and drop the broken inline DATADOG_API_KEY= prefix. DD_API_KEY is already exported and is the correct env var used by datadog-ci. Environment: Datadog workspace Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The global npm install puts the binary in a directory not on PATH in GitLab CI, causing 'datadog-ci: command not found'. Switch to npx which resolves and runs the package without a global install. Environment: Datadog workspace Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dd-sdk-androidto Datadog Code Coverage by properly wiring thedatadog-ci coverage uploadstep in thetest:koverCI job: add--service dd-sdk-android, exportDATADOG_API_KEYfrom Vault, and remove the|| truethat was silently swallowing failures.ci/scripts/codecov.sh(the uploader script),.codecov.yml(config), theDD_ANDROID_SECRET__CODECOV_TOKENsecret reference inci/scripts/vault_config.sh, and thebash <(cat ./ci/scripts/codecov.sh)upload line from thetest:koverCI job.Test plan
test:koverjob runs to completion and coverage is visible in Datadog Code Coverage UI after merge.🤖 Generated with Claude Code