RUM-16325 timeseries: Update RUM JSON schemas and regenerate models#3555
RUM-16325 timeseries: Update RUM JSON schemas and regenerate models#3555satween wants to merge 2 commits into
timeseries: Update RUM JSON schemas and regenerate models#3555Conversation
timeseries: Update RUM JSON schemas and regenerate models
This comment has been minimized.
This comment has been minimized.
0419b26 to
5c8c3b4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/timeseries #3555 +/- ##
======================================================
- Coverage 72.62% 72.59% -0.03%
======================================================
Files 980 980
Lines 36053 36053
Branches 6033 6033
======================================================
- Hits 26181 26171 -10
+ Misses 8198 8197 -1
- Partials 1674 1685 +11
🚀 New features to boost your workflow:
|
Yes, we already have this No call to action, just a thought. I have once concern about this |
The oneOf-primitive option generator kept its own private knownTypes set that was never cleared between files, unlike every other generator which shares (and clears per file) the FileGenerator set. As a result, when two top-level models contained a structurally identical oneOf of primitives (e.g. the Path = oneOf[string,integer] from the shared _graphql schema, referenced by both ResourceEvent and ErrorEvent), the second model's option subclasses extended the first model's nested sealed class (ErrorEvent.String : ResourceEvent.Path()), which fails to compile. Wire the shared knownTypes set into OneOfPrimitiveOptionGenerator so each model resolves its own nested type. Add a dedicated regression test that generates two models sharing an identical oneOf-primitive and asserts the second does not leak a reference to the first's nested type.
5c8c3b4 to
41ecfd9
Compare
Regenerate RUM models and API surface from the updated JSON schemas: new graphql/stream/trace/transition/vital-duration/view_update schemas and updated action/error/resource/view definitions.
41ecfd9 to
147653a
Compare
What does this PR do?
Updates the RUM JSON schemas to the latest definitions and regenerates the corresponding Kotlin models and API surface. Also improves the json-schema code generator so
OneOfPrimitiveOptionGeneratorshares theknownTypesregistry withFileGenerator, avoiding duplicate type resolution.Review checklist (to be filled by reviewers)