Skip to content

RUM-16325 timeseries: Post-review fixes for timeseries#3556

Open
satween wants to merge 1 commit into
tvaleev/feature/timeseries-RUM-16325-schema-updatefrom
tvaleev/feature/timeseries-RUM-16325-post-review
Open

RUM-16325 timeseries: Post-review fixes for timeseries#3556
satween wants to merge 1 commit into
tvaleev/feature/timeseries-RUM-16325-schema-updatefrom
tvaleev/feature/timeseries-RUM-16325-post-review

Conversation

@satween

@satween satween commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Applies post-review fixes from PR on top of the schema update: adjustments to RumFeature, RumSessionScope, TimeseriesConfiguration, and the CPU/Memory event serializers, plus added/updated unit and end-to-end tests.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@satween satween marked this pull request as ready for review June 18, 2026 15:08
@satween satween requested review from a team as code owners June 18, 2026 15:08
@datadog-datadog-prod-us1-2

This comment has been minimized.

@satween satween changed the title RUM-16325: Post-review fixes for timeseries RUM-16325 timeseries: Post-review fixes for timeseries Jun 18, 2026
@satween satween force-pushed the tvaleev/feature/timeseries-RUM-16325-schema-update branch from 4c45d0d to 379720c Compare June 18, 2026 15:09
@satween satween force-pushed the tvaleev/feature/timeseries-RUM-16325-post-review branch from 474fa4a to 1cfa953 Compare June 18, 2026 15:09
@satween satween marked this pull request as draft June 18, 2026 15:10
@satween satween force-pushed the tvaleev/feature/timeseries-RUM-16325-schema-update branch from 379720c to 0419b26 Compare June 18, 2026 15:31
@satween satween force-pushed the tvaleev/feature/timeseries-RUM-16325-post-review branch from 1cfa953 to 61f8681 Compare June 18, 2026 15:31
@satween satween force-pushed the tvaleev/feature/timeseries-RUM-16325-schema-update branch from 0419b26 to 5c8c3b4 Compare June 18, 2026 15:31
@satween satween force-pushed the tvaleev/feature/timeseries-RUM-16325-post-review branch from 61f8681 to 7ab7c75 Compare June 18, 2026 15:31
@satween satween marked this pull request as ready for review June 18, 2026 15:33
@codecov-commenter

codecov-commenter commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.56%. Comparing base (147653a) to head (b4386f7).

Files with missing lines Patch % Lines
...lin/com/datadog/android/rum/internal/RumFeature.kt 50.00% 2 Missing ⚠️
.../android/rum/timeseries/TimeseriesConfiguration.kt 66.67% 1 Missing ⚠️
Additional details and impacted files
@@                                  Coverage Diff                                   @@
##           tvaleev/feature/timeseries-RUM-16325-schema-update    #3556      +/-   ##
======================================================================================
- Coverage                                               72.59%   72.56%   -0.03%     
======================================================================================
  Files                                                     980      980              
  Lines                                                   36053    36056       +3     
  Branches                                                 6033     6031       -2     
======================================================================================
- Hits                                                    26171    26163       -8     
- Misses                                                   8197     8205       +8     
- Partials                                                 1685     1688       +3     
Files with missing lines Coverage Δ
...kotlin/com/datadog/android/rum/RumConfiguration.kt 92.47% <ø> (ø)
...droid/rum/internal/domain/scope/RumSessionScope.kt 92.00% <100.00%> (+0.19%) ⬆️
...ternal/timeseries/serializer/CpuEventSerializer.kt 90.38% <100.00%> (+3.85%) ⬆️
...nal/timeseries/serializer/MemoryEventSerializer.kt 91.23% <100.00%> (+3.51%) ⬆️
.../android/rum/timeseries/TimeseriesConfiguration.kt 90.91% <66.67%> (ø)
...lin/com/datadog/android/rum/internal/RumFeature.kt 91.82% <50.00%> (+0.19%) ⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@satween satween force-pushed the tvaleev/feature/timeseries-RUM-16325-schema-update branch from 5c8c3b4 to 41ecfd9 Compare June 19, 2026 12:27
@satween satween force-pushed the tvaleev/feature/timeseries-RUM-16325-post-review branch from 7ab7c75 to 46addf4 Compare June 19, 2026 12:37
@satween satween force-pushed the tvaleev/feature/timeseries-RUM-16325-schema-update branch from 41ecfd9 to 147653a Compare June 19, 2026 13:17
@satween satween force-pushed the tvaleev/feature/timeseries-RUM-16325-post-review branch from 46addf4 to d87694f Compare June 19, 2026 13:18
@satween satween force-pushed the tvaleev/feature/timeseries-RUM-16325-post-review branch from d87694f to b4386f7 Compare June 19, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants