sds-go: replace ScanWithValidation with ScanWithOptions - #372
Merged
Conversation
vinckama
force-pushed
the
vincent.roy/3849
branch
6 times, most recently
from
July 23, 2026 17:33
5262083 to
6123775
Compare
vinckama
changed the title
Native scan() already takes scan_metadata_json; the Go bindings still called the old 7-arg signature. Expose ScanCallOptions / ScanWithOptions (and the map equivalents), pass metadata or NULL into C.scan, and drop ScanWithValidation / ScanEventsMapWithValidation. TestScanWithOptions configures a CustomHttp third_party_active_checker and asserts MatchStatus is set when ValidateMatching is enabled.
vinckama
force-pushed
the
vincent.roy/3849
branch
from
July 23, 2026 17:40
6123775 to
f6e07cd
Compare
vinckama
marked this pull request as ready for review
July 23, 2026 17:40
fuchsnj
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScanWithValidation/ScanEventsMapWithValidationwithScanWithOptions/ScanEventsMapWithOptionsdriven byScanCallOptions(ValidateMatching,Metadata).scan_metadata_jsonargument through the Go FFI (NULL when metadata is empty) (missing in Add scan metadata)TestScanWithOptionsthat enables match validation viaCustomHttpand assertsMatchStatusis populated.