Simplify CI - #373
Merged
Merged
Conversation
fuchsnj
changed the title
fuchsnj
changed the title
fuchsnj
marked this pull request as ready for review
July 24, 2026 19:22
artslidd
reviewed
Jul 27, 2026
Comment on lines
+7
to
+8
| cargo hack check --each-feature --no-dev-deps | ||
| cargo hack clippy --each-feature --no-dev-deps -- -D warnings |
Contributor
Author
There was a problem hiding this comment.
This basically just does a loop over all of the features and builds the library with each individual one. This will help prevent us from having to manually list the different features anytime it changes.
artslidd
reviewed
Jul 27, 2026
| build-sds-go: ## Build the sds-go lib (third-party active checkers included by default). | ||
| @echo "Building sds-go lib" | ||
| cargo build --manifest-path="sds/Cargo.toml" --release --features dd_sds_go | ||
| cd sds && cargo build --release --features dd_sds_go |
Contributor
There was a problem hiding this comment.
how is cd ... && better than using the manifest-path command arg?
Contributor
Author
There was a problem hiding this comment.
It's not really. Just slightly shorter / easier to read. Should do the same thing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
This does some general CI cleanup. Mostly switching out some of the Rust feature testing for
cargo hackto automatically test all features individually