Add support for HotChocolate v16.x#8802
Draft
andrewlock wants to merge 9 commits into
Draft
Conversation
andrewlock
added
area:tracer
BenchmarksBenchmark execution time: 2026-06-19 18:08:12 Comparing candidate commit 7fa14dc in PR branch Found 1 performance improvements and 1 performance regressions! Performance is the same for 70 metrics, 0 unstable metrics, 62 known flaky benchmarks, 64 flaky benchmarks without significant changes.
|
This comment has been minimized.
This comment has been minimized.
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8802) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8802) - mean (70ms) : 68, 72
master - mean (74ms) : 71, 78
section Bailout
This PR (8802) - mean (76ms) : 72, 80
master - mean (78ms) : 75, 81
section CallTarget+Inlining+NGEN
This PR (8802) - mean (1,081ms) : 1040, 1123
master - mean (1,094ms) : 1053, 1135
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8802) - mean (109ms) : 106, 112
master - mean (116ms) : 110, 121
section Bailout
This PR (8802) - mean (114ms) : 109, 118
master - mean (114ms) : 111, 117
section CallTarget+Inlining+NGEN
This PR (8802) - mean (776ms) : 756, 795
master - mean (786ms) : 770, 803
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8802) - mean (96ms) : 93, 99
master - mean (104ms) : 98, 111
section Bailout
This PR (8802) - mean (101ms) : 96, 105
master - mean (102ms) : 98, 107
section CallTarget+Inlining+NGEN
This PR (8802) - mean (937ms) : 895, 980
master - mean (947ms) : 914, 980
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8802) - mean (96ms) : 91, 101
master - mean (100ms) : 97, 102
section Bailout
This PR (8802) - mean (96ms) : 94, 97
master - mean (103ms) : 99, 107
section CallTarget+Inlining+NGEN
This PR (8802) - mean (812ms) : 781, 844
master - mean (823ms) : 780, 865
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8802) - mean (203ms) : 198, 208
master - mean (200ms) : 195, 205
section Bailout
This PR (8802) - mean (205ms) : 202, 207
master - mean (205ms) : 201, 209
section CallTarget+Inlining+NGEN
This PR (8802) - mean (1,210ms) : 1172, 1248
master - mean (1,204ms) : 1159, 1249
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8802) - mean (288ms) : 283, 294
master - mean (289ms) : 282, 297
section Bailout
This PR (8802) - mean (288ms) : 279, 296
master - mean (290ms) : 285, 295
section CallTarget+Inlining+NGEN
This PR (8802) - mean (964ms) : 943, 985
master - mean (976ms) : 952, 1001
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8802) - mean (280ms) : 274, 286
master - mean (281ms) : 274, 287
section Bailout
This PR (8802) - mean (281ms) : 277, 284
master - mean (281ms) : 276, 286
section CallTarget+Inlining+NGEN
This PR (8802) - mean (1,166ms) : 1124, 1208
master - mean (1,165ms) : 1129, 1201
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8802) - mean (278ms) : 271, 286
master - mean (281ms) : 274, 287
section Bailout
This PR (8802) - mean (277ms) : 271, 283
master - mean (280ms) : 274, 286
section CallTarget+Inlining+NGEN
This PR (8802) - mean (1,042ms) : 1006, 1078
master - mean (1,042ms) : 1003, 1082
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
andrewlock
force-pushed
the
andrew/updat-hotchocolate
branch
from
9771914 to
656d27b
Compare
andrewlock
changed the title
HotChocolate v16.x
Contributor
Snapshots difference summaryThe following differences have been observed in committed snapshots. It is meant to help the reviewer. 4 occurrences of : - events: [{"name":"dd.graphql.query.error","time_unix_nano":<DateTimeOffset.Now>,"attributes":{"message":"Unexpected Execution Error","locations":["1:18"],"path":["throwException"],"stacktrace":" at Samples.HotChocolate.Query.ThrowException() in Query.cs:line 00","extensions.int":1,"extensions.float":1.1,"extensions.str":"1","extensions.bool":true,"extensions.other":"[1,foo]","extensions.sbyte":-42,"extensions.byte":42,"extensions.short":-1000,"extensions.ushort":1000,"extensions.uint":4294967295,"extensions.long":-9223372036854775808,"extensions.ulong":"18446744073709551615","extensions.decimal":"3.14159265358979","extensions.double":3.141592653589793,"extensions.char":"A"}}],
+ events: [{"name":"dd.graphql.query.error","time_unix_nano":<DateTimeOffset.Now>,"attributes":{"message":"Unexpected Execution Error","path":["throwException"],"stacktrace":" at Samples.HotChocolate.Query.ThrowException() in Query.cs:line 00","extensions.int":1,"extensions.float":1.1,"extensions.str":"1","extensions.bool":true,"extensions.other":"[1,foo]","extensions.sbyte":-42,"extensions.byte":42,"extensions.short":-1000,"extensions.ushort":1000,"extensions.uint":4294967295,"extensions.long":-9223372036854775808,"extensions.ulong":"18446744073709551615","extensions.decimal":"3.14159265358979","extensions.double":3.141592653589793,"extensions.char":"A"}}],
2 occurrences of : - events: [{"name":"dd.graphql.query.error","time_unix_nano":<DateTimeOffset.Now>,"attributes":{"message":"Unexpected Execution Error","locations":["1:18"],"path":["throwExceptionIndex"],"stacktrace":" at Samples.HotChocolate.Query.ThrowExceptionIndex() in Query.cs:line 00","extensions.int":1,"extensions.float":1.1,"extensions.str":"1","extensions.bool":true,"extensions.other":"[1,foo]","extensions.sbyte":-42,"extensions.byte":42,"extensions.short":-1000,"extensions.ushort":1000,"extensions.uint":4294967295,"extensions.long":-9223372036854775808,"extensions.ulong":"18446744073709551615","extensions.decimal":"3.14159265358979","extensions.double":3.141592653589793,"extensions.char":"A"}}],
+ events: [{"name":"dd.graphql.query.error","time_unix_nano":<DateTimeOffset.Now>,"attributes":{"message":"Unexpected Execution Error","path":["throwExceptionIndex"],"stacktrace":" at Samples.HotChocolate.Query.ThrowExceptionIndex() in Query.cs:line 00","extensions.int":1,"extensions.float":1.1,"extensions.str":"1","extensions.bool":true,"extensions.other":"[1,foo]","extensions.sbyte":-42,"extensions.byte":42,"extensions.short":-1000,"extensions.ushort":1000,"extensions.uint":4294967295,"extensions.long":-9223372036854775808,"extensions.ulong":"18446744073709551615","extensions.decimal":"3.14159265358979","extensions.double":3.141592653589793,"extensions.char":"A"}}],
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Updates the tested version of HotChocolate.AspNetCore to latest major
Reason for change
We want to support the latest majors
Implementation details
There were a lot of changes of the internals in v16. The main one I found was the move/rename of
RequestExecutortoDefaultRequestExecutorand moving to another assemblyTest coverage
Updated