Skip to content

Checkout PR ref when creating mirror images #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarahchen6 merged 2 commits into from
Jul 6, 2026
Merged

Checkout PR ref when creating mirror images #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbaeb1e
Checkout PR ref
sarahchen6 Jul 2, 2026
6a4b7bd
Delete from PR as well
sarahchen6 Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/create-test-mirror-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
path: dd-trace-java-docker-build
ref: refs/pull/${{ github.event.inputs.pr_number }}/merge
Comment thread
sarahchen6 marked this conversation as resolved.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD Jul 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking if we really need this?
I think that if we need to update CI_VARAINTS we can simply merge that to master in order not to produce one-time-use images. WDYT?
Or probably we better start working on moving this image into dd-trace-java directly.
I recall @bric3 mentioned that it is very possible.

@sarahchen6 sarahchen6 Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that if we need to update CI_VARAINTS we can simply merge that to master in order not to produce one-time-use images. WDYT?

We'd only produce one extra one-time-use image (for the new variant) in the same group that gets deleted with the other test CI images 🤔 - which reminds me to apply this to the delete workflow too. The changes don't add any permanent images or additional workflows.

The CI_VARIANTS variable determines how the images are tagged, so if we added the variant to master first, we'd be adding a new tagged image to the master workflow without it being tested.

I think it makes more sense to be updating the CI_VARIANTS tagging in the same PR that the image itself is tested and added.

probably we better start working on moving this image into dd-trace-java directly.

This comment explains why we should stick to two separate workflows.


- name: Checkout DataDog/images
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/delete-test-mirror-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
path: dd-trace-java-docker-build
ref: refs/pull/${{ github.event.inputs.pr_number }}/merge

- name: Checkout DataDog/images
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
Expand Down
Loading