Skip to content

Remove PR ref from delete workflow #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarahchen6 merged 1 commit into from
Jul 7, 2026
Merged

Remove PR ref from delete workflow #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/delete-test-mirror-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ jobs:
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
path: dd-trace-java-docker-build

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve cleanup for unmerged variant-change PRs

When cleanup is needed before the source PR is merged or after it is closed without merging, this now checks out the default workflow ref instead of the PR ref. The create workflow still runs the PR version of scripts/create-test-mirror-entries.sh, which writes tags from that PR's CI_VARIANTS, while delete-test-mirror-entries.sh reconstructs an exact mirror.yaml block from the checked-out script and exits if it does not match. A PR that adds/removes a variant can therefore create mirror entries that this delete workflow cannot remove unless the PR has already landed; consider falling back to the PR ref when it exists or deleting by prefix rather than by the default-branch variant list.

Useful? React with 👍 / 👎.

ref: refs/pull/${{ github.event.inputs.pr_number }}/merge

- name: Checkout DataDog/images
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
Expand Down
Loading