Skip to content

Limit OpenFeature fixture submodule updates#11867

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
leo.romanovsky/limit-openfeature-submodule-dependabot
Jul 7, 2026
Merged

Limit OpenFeature fixture submodule updates#11867
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
leo.romanovsky/limit-openfeature-submodule-dependabot

Conversation

@leoromanovsky

@leoromanovsky leoromanovsky commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Motivation

PR #11355 added Dependabot updates for git submodules so the OpenFeature fixture corpus can stay current. Because the rule was scoped to the repository root without an allow-list, Dependabot also started opening JMX Fetch submodule updates, such as #11863. Those updates should remain owned by the existing JMX/APM Java flow, while OpenFeature fixture updates should be labeled and routed to the FFE SDK team.

Changes

This PR restricts the gitsubmodule Dependabot rule to dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data using an explicit allow entry.

It also applies the expected labels to generated OpenFeature fixture submodule PRs:

  • comp: openfeature
  • tag: dependencies
  • tag: no release notes

Decisions

I kept directory: / because Dependabot reads git submodules from the repository .gitmodules file. The narrower allow rule is the guardrail that prevents the same automation from updating dd-java-agent/agent-jmxfetch/integrations-core.

The follow-up request also asked about CODEOWNERS assignment. I checked that path before changing it: the existing /dd-smoke-tests/openfeature/ CODEOWNERS rule already covers dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data, including the submodule gitlink path that changes in fixture update PRs. Adding an exact duplicate owner line would not change routing, so this PR intentionally leaves CODEOWNERS unchanged.

Validation

  • ruby -e "require 'yaml'; YAML.load_file('.github/dependabot.yml'); puts 'dependabot.yml OK'"
  • git config -f .gitmodules --get-regexp '^submodule\\..*\\.path$'
  • git diff --check

@leoromanovsky leoromanovsky added type: bug fix Bug fix comp: openfeature OpenFeature tag: dependencies Dependencies related changes tag: no release notes Changes to exclude from release notes tag: ai generated Largely based on code generated by an AI or LLM labels Jul 6, 2026
@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jul 6, 2026

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 56.92% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 24e949c | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.76 s 14.68 s [-0.2%; +1.3%] (no difference)
startup:insecure-bank:tracing:Agent 13.70 s 13.71 s [-0.9%; +0.8%] (no difference)
startup:petclinic:appsec:Agent 16.90 s 16.60 s [+0.7%; +2.9%] (maybe worse)
startup:petclinic:iast:Agent 16.26 s 16.94 s [-8.3%; +0.3%] (no difference)
startup:petclinic:profiling:Agent 16.70 s 16.91 s [-2.3%; -0.2%] (maybe better)
startup:petclinic:sca:Agent 16.94 s 16.65 s [+0.8%; +2.7%] (maybe worse)
startup:petclinic:tracing:Agent 16.02 s 15.92 s [-0.4%; +1.6%] (no difference)

Commit: 24e949cd · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@leoromanovsky leoromanovsky marked this pull request as ready for review July 6, 2026 14:09
@leoromanovsky leoromanovsky requested a review from a team as a code owner July 6, 2026 14:09
@leoromanovsky leoromanovsky requested review from PerfectSlayer and removed request for a team July 6, 2026 14:09

@PerfectSlayer PerfectSlayer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up commit!

@leoromanovsky leoromanovsky enabled auto-merge July 6, 2026 15:48
@leoromanovsky leoromanovsky disabled auto-merge July 7, 2026 15:25
@leoromanovsky leoromanovsky enabled auto-merge July 7, 2026 15:26
@leoromanovsky

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 7, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-07 15:29:05 UTC ℹ️ Start processing command /merge


2026-07-07 15:29:15 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-07-07 16:23:13 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-07-07 18:23:44 UTCMergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 8972795207992346701 took longer than expected. The current limit for the base branch 'master' is 120 minutes.

@leoromanovsky leoromanovsky added this pull request to the merge queue Jul 7, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 7, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-07 16:22:43 UTC ℹ️ Start processing command /merge


2026-07-07 16:22:45 UTC ❌ MergeQueue

PR already in the queue with status waiting

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 7, 2026
@leoromanovsky leoromanovsky added this pull request to the merge queue Jul 7, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 7, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-07 18:33:56 UTC ℹ️ Start processing command /merge


2026-07-07 18:34:00 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-07-07 19:39:45 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 7, 2026
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit a607d2a into master Jul 7, 2026
589 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the leo.romanovsky/limit-openfeature-submodule-dependabot branch July 7, 2026 19:39
@github-actions github-actions Bot added this to the 1.64.0 milestone Jul 7, 2026
kaahos pushed a commit that referenced this pull request Jul 8, 2026
Limit OpenFeature fixture submodule updates

Remove redundant OpenFeature CODEOWNERS entry

Merge branch 'master' into leo.romanovsky/limit-openfeature-submodule-dependabot

Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: openfeature OpenFeature tag: ai generated Largely based on code generated by an AI or LLM tag: dependencies Dependencies related changes tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants