Skip to content

Move test classloaders to Java#11911

Open
AlexeyKuznetsov-DD wants to merge 1 commit into
masterfrom
alexeyk/move-test-classloaders-to-java
Open

Move test classloaders to Java#11911
AlexeyKuznetsov-DD wants to merge 1 commit into
masterfrom
alexeyk/move-test-classloaders-to-java

Conversation

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor

What Does This Do

Moves ClassLoader test helpers from Groovy to Java and removes the obsolete Java 8 Groovy compiler overrides.

Motivation

Groovy generates synthetic accessors that reference java.lang.Module, breaking Java 8-compatible test bytecode.

Additional Notes

Validated by compiling both affected modules, running CI Visibility tests on Java 8, and running the affected exception-handler tests on Java 17.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix comp: ci visibility Continuous Integration Visibility comp: tooling Build & Tooling labels Jul 10, 2026
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Jul 10, 2026
@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jul 10, 2026

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 56.58% (-0.46%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5dbe077 | Docs | Datadog PR Page | Give us feedback!

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD marked this pull request as ready for review July 10, 2026 16:50
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested review from a team as code owners July 10, 2026 16:50

@datadog-prod-us1-3 datadog-prod-us1-3 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

Migration from Groovy to Java classloaders to resolve Java 8 compatibility issue caused by Groovy's synthetic accessor generation. Code is functionally equivalent, properly scoped, and follows test conventions. No regressions detected.

Was this helpful? React 👍 or 👎

📊 Validated against 5 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 5dbe077 · What is Autotest? · Any feedback? Reach out in #autotest

@dd-octo-sts

dd-octo-sts Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.98 s 14.02 s [-1.1%; +0.6%] (no difference)
startup:insecure-bank:tracing:Agent 12.91 s 13.03 s [-1.7%; -0.3%] (maybe better)
startup:petclinic:appsec:Agent 16.89 s 16.68 s [+0.1%; +2.3%] (maybe worse)
startup:petclinic:iast:Agent 16.97 s 16.88 s [-0.3%; +1.3%] (no difference)
startup:petclinic:profiling:Agent 16.82 s 16.66 s [-0.2%; +2.1%] (no difference)
startup:petclinic:sca:Agent 16.89 s 16.66 s [+0.2%; +2.5%] (maybe worse)
startup:petclinic:tracing:Agent 15.64 s 16.20 s [-7.5%; +0.7%] (no difference)

Commit: 5dbe0776 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@sarahchen6 sarahchen6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Should probably wait for Brice's eye though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: ci visibility Continuous Integration Visibility comp: tooling Build & Tooling tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants