Add datadog.common.filesystem to list of bootstrap package prefixes#11914
Conversation
cae77a4 to
4ad233a
Compare
|
🎯 Code Coverage (details) 🔗 Commit SHA: 4ad233a | Docs | Datadog PR Page | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
There was a problem hiding this comment.
More details
This PR adds datadog.common.filesystem to the bootstrap package prefixes, fixing NoClassDefFoundError when StableConfigSource (which uses Files.exists()) initializes during test setup. The change is minimal, non-breaking, and correctly synchronized across both the main constant list and its test copy. No behavioral regressions detected.
📊 Validated against 3 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 4ad233a · What is Autotest? · Any feedback? Reach out in #autotest
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 4949855003353360450 took longer than expected. The current limit for the base branch 'master' is 120 minutes. |
| */ | ||
| public static final String[] BOOTSTRAP_PACKAGE_PREFIXES = { | ||
| "datadog.slf4j", | ||
| "datadog.common.filesystem", |
There was a problem hiding this comment.
Any chance to cover with test? If that possible at all?
There was a problem hiding this comment.
I'd prefer if we had a general rule about unexpected exceptions in test logs - but that wouldn't be part of this PR, more a new test utility. You'd have to filter out expected exceptions but having that general check enabled across CI would have caught this as well as some previous cases which I only spotted manually.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 14005003475570071 took longer than expected. The current limit for the base branch 'master' is 120 minutes. |
Motivation
Hopefully fixes the following log-spam when running instrumentation tests on CI:
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]