Skip to content

Add datadog.common.filesystem to list of bootstrap package prefixes#11914

Merged
mcculls merged 1 commit into
masterfrom
mcculls/add-dd-common-fs-to-boostrap-list
Jul 11, 2026
Merged

Add datadog.common.filesystem to list of bootstrap package prefixes#11914
mcculls merged 1 commit into
masterfrom
mcculls/add-dd-common-fs-to-boostrap-list

Conversation

@mcculls

@mcculls mcculls commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Motivation

Hopefully fixes the following log-spam when running instrumentation tests on CI:

14:42:03.913 [Test worker] DEBUG datadog.trace.bootstrap.config.provider.StableConfigSource - Stable configuration file found at path: /etc/datadog-agent/application_monitoring.yaml
14:42:03.920 [Test worker] ERROR datadog.trace.bootstrap.config.provider.StableConfigSource - Unexpected error while reading stable configuration file: /etc/datadog-agent/application_monitoring.yaml
java.lang.NoClassDefFoundError: datadog/common/filesystem/Files
	at datadog.trace.bootstrap.config.provider.StableConfigSource.<init>(StableConfigSource.java:37)
	at datadog.trace.bootstrap.config.provider.StableConfigSource.<clinit>(StableConfigSource.java:22)
	at datadog.trace.bootstrap.config.provider.ConfigProvider.createDefault(ConfigProvider.java:523)
	at datadog.trace.bootstrap.config.provider.ConfigProvider$Singleton.<clinit>(ConfigProvider.java:34)
	at datadog.trace.bootstrap.config.provider.ConfigProvider.getInstance(ConfigProvider.java:504)
	at datadog.trace.api.InstrumenterConfig.<clinit>(InstrumenterConfig.java:749)
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:264)
	at datadog.trace.test.util.DDSpecification.makeConfigInstanceModifiable(DDSpecification.groovy:70)
	at datadog.trace.test.util.DDSpecification.<clinit>(DDSpecification.groovy:29)

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mcculls mcculls added type: bug fix Bug fix comp: testing Testing tag: no release notes Changes to exclude from release notes labels Jul 10, 2026
@mcculls mcculls force-pushed the mcculls/add-dd-common-fs-to-boostrap-list branch from cae77a4 to 4ad233a Compare July 10, 2026 20:46
@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jul 10, 2026

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.97% (+3.93%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4ad233a | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.94 s 14.00 s [-1.1%; +0.3%] (no difference)
startup:insecure-bank:tracing:Agent 12.95 s 13.00 s [-1.1%; +0.3%] (no difference)
startup:petclinic:appsec:Agent 16.84 s 16.67 s [+0.0%; +2.1%] (maybe worse)
startup:petclinic:iast:Agent 16.87 s 16.95 s [-1.3%; +0.3%] (no difference)
startup:petclinic:profiling:Agent 16.10 s 16.87 s [-8.9%; -0.3%] (maybe better)
startup:petclinic:sca:Agent 16.92 s 16.73 s [+0.1%; +2.2%] (maybe worse)
startup:petclinic:tracing:Agent 15.94 s 15.63 s [-2.4%; +6.2%] (no difference)

Commit: 4ad233ae · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@mcculls mcculls marked this pull request as ready for review July 10, 2026 21:22
@mcculls mcculls requested a review from a team as a code owner July 10, 2026 21:22
@mcculls mcculls requested a review from dougqh July 10, 2026 21:22

@datadog-prod-us1-3 datadog-prod-us1-3 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

This PR adds datadog.common.filesystem to the bootstrap package prefixes, fixing NoClassDefFoundError when StableConfigSource (which uses Files.exists()) initializes during test setup. The change is minimal, non-breaking, and correctly synchronized across both the main constant list and its test copy. No behavioral regressions detected.

Was this helpful? React 👍 or 👎

📊 Validated against 3 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 4ad233a · What is Autotest? · Any feedback? Reach out in #autotest

@mcculls mcculls added this pull request to the merge queue Jul 10, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 10, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-10 23:19:24 UTC ℹ️ Start processing command /merge


2026-07-10 23:19:29 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-07-11 01:19:47 UTCMergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 4949855003353360450 took longer than expected. The current limit for the base branch 'master' is 120 minutes.

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 10, 2026
*/
public static final String[] BOOTSTRAP_PACKAGE_PREFIXES = {
"datadog.slf4j",
"datadog.common.filesystem",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance to cover with test? If that possible at all?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if we had a general rule about unexpected exceptions in test logs - but that wouldn't be part of this PR, more a new test utility. You'd have to filter out expected exceptions but having that general check enabled across CI would have caught this as well as some previous cases which I only spotted manually.

@mcculls mcculls added this pull request to the merge queue Jul 11, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 11, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-11 11:11:38 UTC ℹ️ Start processing command /merge


2026-07-11 11:11:42 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-07-11 13:12:03 UTCMergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 14005003475570071 took longer than expected. The current limit for the base branch 'master' is 120 minutes.

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 11, 2026
@mcculls mcculls merged commit 0c91932 into master Jul 11, 2026
783 of 786 checks passed
@mcculls mcculls deleted the mcculls/add-dd-common-fs-to-boostrap-list branch July 11, 2026 13:19
@github-actions github-actions Bot added this to the 1.65.0 milestone Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testing Testing tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants