skill(apm-integrations): clarify + consolidate Groovy-vs-Java test DSL rule - #12359
Draft
jordan-wong wants to merge 2 commits into
Draft
skill(apm-integrations): clarify + consolidate Groovy-vs-Java test DSL rule#12359jordan-wong wants to merge 2 commits into
jordan-wong wants to merge 2 commits into
Conversation
… source of truth "Full Java instrumentation test support is not yet available" read as an absolute ban, but the repo has real Java/JUnit instrumentation test suites for module families already on that DSL. Rewrote the rule to state plainly: Groovy/Spock is unconditional for new tests; an existing Java-DSL sibling is not license to add more Java tests, and is not license to migrate a Groovy family to Java either. Stated once in tests.md (the single source of truth); SKILL.md and the banner-comments section point to it rather than restating it, so there's one place to update instead of several with slightly different wording. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jordan-wong
added
tag: ai generated
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
jordan-wong
changed the title
- SKILL.md Step 4: collapsed the 2-line source-layout bullet into the directory-creation
line; test dir is already governed by Step 9.1, no need to name it twice.
- tests.md: cut the TagsMatcher.defaultTags()/_dd.svc_src mechanism detail from the DSL
rule — the consequence ("diverges from master's style, trips the stricter tag matcher")
is enough for the rule; the exact internals aren't needed to follow it.
- tests.md banner-comments section: replaced a full caveat sentence with a one-line
comment inside the code fence itself, next to the code it's caveating.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies the Groovy-vs-Java test DSL rule so it's stated once instead of ambiguously in one place.
Changes
references/tests.md§1 rewrote "Full Java instrumentation test support is not yet available" — which reads as if Java/JUnit tests are unavailable, but the repo has real Java-DSL instrumentation test suites — into a plain, unconditional statement: Groovy/Spock for new instrumentation tests; an existing Java-DSL sibling is not license to add more Java tests, and is not license to migrate a Groovy family to Java either.SKILL.mdand the banner-comments section point to this one statement instead of restating it, so there's a single place to update.Scope
references/tests.md,SKILL.md— docs-only.Follows up on #12164 (which introduced a conditional exception that was flagged as contradicting repo convention — this PR states the rule plainly instead).