feat(browser-bunyan): Add new browser-bunyan integration - #9701
Open
ngbrown wants to merge 1 commit into
Open
Conversation
ngbrown
requested review from
BridgeAR and
wconti27
and removed request for
a team
August 5, 2026 15:38
Member
|
I opened a port for the PR. I guess there should not be much that blocks it, since it is an easy addition. Thank you for the PR. I can not yet guarantee that it will land though |
ngbrown
force-pushed
the
integrate-browser-bunyan
branch
from
August 5, 2026 22:15
4964e22 to
0a3f314
Compare
ngbrown
force-pushed
the
integrate-browser-bunyan
branch
from
August 5, 2026 22:23
0a3f314 to
0748679
Compare
Author
|
I figured out how to get the commit signed. Let me know if you have any feedback on the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull requests integrates
dd-tracewith the logging librarybrowser-bunyan, when it is running on the server-side in Node.js.Motivation
As frameworks such as Next.js and Remix focus on isomorphic React, the logging library should be isomorphic. I've found
browser-bunyanto fit the bill of something lightweight and very usable.For example, if a web app is attempting to follow the twelve-factor methodology, then it only needs to write its event stream, unbuffered, to stdout, so a simpler the logging library is better.
Additional Notes
I previously submitted #1935 in 2022 but without it getting merged I continued using this integration via a local patch. Now I've re-built it with the current state of the
dd-tracelibrary and am re-submitting.The tests are very similar to the
bunyanintegration tests, with some minor differences to convert the console output to JSON. The user would be expected to do the same in their Node.js application.