Fix K8s lib injection ruff rules (ANN201, B006, B007, B904)#7021
Open
robertomonteromiguel wants to merge 1 commit into
Open
Fix K8s lib injection ruff rules (ANN201, B006, B007, B904)#7021robertomonteromiguel wants to merge 1 commit into
robertomonteromiguel wants to merge 1 commit into
Conversation
Enable ANN201, B006, B007, and B904 in K8s lib injection utilities by adding return types, avoiding mutable defaults, and fixing exception chaining. Drop the corresponding per-file-ignores from pyproject.toml. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
|
|
cbeauchesne
reviewed
May 26, 2026
| with_datadog_operator: bool = False, | ||
| with_cluster_agent: bool = True, | ||
| scenario_groups: list[ScenarioGroup] = [scenario_groups.all, scenario_groups.lib_injection], | ||
| scenario_groups: list[ScenarioGroup] | None = None, |
Collaborator
There was a problem hiding this comment.
This change breaks group, no ?
Collaborator
Author
There was a problem hiding this comment.
it shouldn't ...I guess... Line 42:
if scenario_groups is None: scenario_groups = DEFAULT_K8S_SCENARIO_GROUPS
cbeauchesne
approved these changes
May 26, 2026
Collaborator
cbeauchesne
left a comment
cbeauchesne
left a comment
There was a problem hiding this comment.
just a small non blocking question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
raiseinstead ofraise e, B904).pyproject.tomlforutils/k8s_lib_injection/*andutils/_context/_scenarios/k8s_lib_injection.py.Test plan
ruff check utils/k8s_lib_injection/ utils/_context/_scenarios/k8s_lib_injection.pyMade with Cursor