test(otlp-trace-metrics): align cross-tracer attributes - #7466
Merged
Conversation
Contributor
|
|
This was referenced Aug 6, 2026
mabdinur
commented
Aug 6, 2026
mabdinur
requested review from
jandro996,
manuel-alvarez-alvarez and
zacharycmontoya
and removed request for
a team
August 6, 2026 19:47
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d1f2911d52
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
mabdinur
marked this pull request as draft
August 6, 2026 20:03
mabdinur
marked this pull request as ready for review
August 6, 2026 20:48
zacharycmontoya
approved these changes
Aug 6, 2026
zacharycmontoya
left a comment
Contributor
There was a problem hiding this comment.
LGTM feature-wise with a couple of comments
mabdinur
enabled auto-merge (squash)
August 6, 2026 21:18
🎉 All green!🧪 All tests passed 🔗 Commit SHA: e6a20a1 | Docs | Datadog PR Page | Give us feedback! |
gh-worker-dd-mergequeue-cf854d Bot
pushed a commit
to DataDog/dd-trace-go
that referenced
this pull request
Aug 7, 2026
### What does this PR do? - Makes OTLP trace metrics ignore `DD_TRACE_OTEL_SEMANTICS_ENABLED`; available OTel and `datadog.*` resource/data-point attributes are always emitted together. - Exports a non-empty `ClientGroupedStats.ServiceSource` as the OTLP string attribute `datadog.svc_src` and omits it when absent. - Removes trace-metrics-only mode plumbing while preserving OTel-semantics behavior for trace export. - Emits known trace-root values as native Booleans and omits unset or unrecognized values. Adds focused coverage for unconditional attributes and service-source presence, absence, and typing. ### Motivation Follow-up to merged #5130 for the revised cross-SDK OTLP trace-metrics contract. Shared coverage is tracked in DataDog/system-tests#7466. ### Validation - `go test ./ddtrace/tracer -count=1` - `go vet ./ddtrace/tracer` - `make format/go` - `./bin/golangci-lint run --new-from-rev=origin/main ./ddtrace/tracer` ### Reviewer's Checklist - [x] Changed code has focused unit coverage. - [x] Shared system-test coverage is added in DataDog/system-tests#7466. - [x] No generated files, dependencies, or public APIs changed. Co-authored-by: munir.abdinur <munir.abdinur@datadoghq.com>
nccatoni
pushed a commit
that referenced
this pull request
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test_FR07_Otel_Semantics_Mode, its fixture, and related documentation because OTLP trace metrics always emit supporteddatadog.*attributes.irrelevantmanifest tombstones.datadog.svc_src, Booleandatadog.is_trace_root, anddatadog.span.top_levelvalues._dd.svc_srcis derived by each tracer rather than injected by the test.DD_TRACE_STATS_ADDITIONAL_TAGSusing each tracer's experimental-feature configuration and narrows manifest gates to individual unsupported tests.Implementation PRs:
.NET process-tag and peer-tag support remains separate in #9002.
Validation