Skip to content

skill(verify-datafog): correct German entity type names - #205

Merged
sidmohan0 merged 1 commit into
mainfrom
cursor/skill-verify-datafog-german-entities-46d9
Oct 30, 2026
Merged

sidmohan0 merged 1 commit into
mainfrom
cursor/skill-verify-datafog-german-entities-46d9

Conversation

@sidmohan0

@sidmohan0 sidmohan0 commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Correct the German locale entity type names in the verify-datafog skill's entities.md feature map.

Drifted claims

The skill claimed entity names using a GERMAN_* prefix, but the actual Core API uses a DE_* prefix:

Skill claimed Actual (corrected)
GERMAN_IBAN DE_IBAN
GERMAN_VAT_ID DE_VAT_ID
GERMAN_TAX_ID DE_TAX_ID
GERMAN_SOCIAL_SECURITY DE_SOCIAL_SECURITY_NUMBER
GERMAN_POSTAL_CODE DE_POSTAL_CODE
GERMAN_PASSPORT DE_PASSPORT_NUMBER
GERMAN_RESIDENCE_PERMIT DE_RESIDENCE_PERMIT_NUMBER

Verification commands and results

Environment setup:

cargo dfv doctor --json
# pass: true, all 11 checks pass

Capabilities check:

python3 -c "from datafog_core import capabilities; import json; c=capabilities(); print([e for e in c['supported_entities'] if e.startswith('DE_')])"
# ['DE_IBAN', 'DE_PASSPORT_NUMBER', 'DE_POSTAL_CODE', 'DE_RESIDENCE_PERMIT_NUMBER', 'DE_SOCIAL_SECURITY_NUMBER', 'DE_TAX_ID', 'DE_VAT_ID']

Scan verification:

python3 -c "from datafog_core import scan; print([f.entity_type for f in scan('IBAN DE89370400440532013000', {'locale': 'de'})])"
# ['DE_IBAN']

Full verification suite:

cargo dfv check --json
# pass: true, all SDKs pass (rust, python, node, wasm)

cargo dfv smoke --json
# pass: true, all SDKs pass

No other drift found

Verified:

  • Doctor checks list matches actual checks
  • Parity commands documented in SKILL.md match CLI help
  • Default entity list (16 entities) matches capabilities output
  • Model identity constants match code (MODEL_REVISION, RUNTIME_REVISION)
  • Playwright version claim matches package.json (1.62.1)
  • WASM restore/tokenize limitations documented correctly
Open in Web Open in Cursor 

Changelog exemption: Correct internal agent verification instructions; no shipped SDK, runtime or public API changes.

Update entities.md to use actual DE_* entity type names instead of
GERMAN_* names.

Drifted claims (old → corrected):
- GERMAN_IBAN → DE_IBAN
- GERMAN_VAT_ID → DE_VAT_ID
- GERMAN_TAX_ID → DE_TAX_ID
- GERMAN_SOCIAL_SECURITY → DE_SOCIAL_SECURITY_NUMBER
- GERMAN_POSTAL_CODE → DE_POSTAL_CODE
- GERMAN_PASSPORT → DE_PASSPORT_NUMBER
- GERMAN_RESIDENCE_PERMIT → DE_RESIDENCE_PERMIT_NUMBER

Verified against capabilities() output and actual scan results:
  python3 -c "from datafog_core import capabilities; print(capabilities())"
  python3 -c "from datafog_core import scan; print([f.entity_type for f in scan('IBAN DE89370400440532013000', {'locale': 'de'})])"
  # Output: ['DE_IBAN']

Co-authored-by: Sid Mohan <sidmohan0@users.noreply.github.com>
@sidmohan0 sidmohan0 added the no-changelog No user-facing change; requires Changelog exemption reason in PR body label Oct 30, 2026
@sidmohan0 sidmohan0 closed this Oct 30, 2026
@sidmohan0 sidmohan0 reopened this Oct 30, 2026
@sidmohan0
sidmohan0 merged commit aad1a11 into main Oct 30, 2026
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No user-facing change; requires Changelog exemption reason in PR body

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants