Repository navigation
skill(verify-datafog): correct German entity type names - #205
Merged
Merged
Conversation
Update entities.md to use actual DE_* entity type names instead of
GERMAN_* names.
Drifted claims (old → corrected):
- GERMAN_IBAN → DE_IBAN
- GERMAN_VAT_ID → DE_VAT_ID
- GERMAN_TAX_ID → DE_TAX_ID
- GERMAN_SOCIAL_SECURITY → DE_SOCIAL_SECURITY_NUMBER
- GERMAN_POSTAL_CODE → DE_POSTAL_CODE
- GERMAN_PASSPORT → DE_PASSPORT_NUMBER
- GERMAN_RESIDENCE_PERMIT → DE_RESIDENCE_PERMIT_NUMBER
Verified against capabilities() output and actual scan results:
python3 -c "from datafog_core import capabilities; print(capabilities())"
python3 -c "from datafog_core import scan; print([f.entity_type for f in scan('IBAN DE89370400440532013000', {'locale': 'de'})])"
# Output: ['DE_IBAN']
Co-authored-by: Sid Mohan <sidmohan0@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the German locale entity type names in the verify-datafog skill's entities.md feature map.
Drifted claims
The skill claimed entity names using a
GERMAN_*prefix, but the actual Core API uses aDE_*prefix:GERMAN_IBANDE_IBANGERMAN_VAT_IDDE_VAT_IDGERMAN_TAX_IDDE_TAX_IDGERMAN_SOCIAL_SECURITYDE_SOCIAL_SECURITY_NUMBERGERMAN_POSTAL_CODEDE_POSTAL_CODEGERMAN_PASSPORTDE_PASSPORT_NUMBERGERMAN_RESIDENCE_PERMITDE_RESIDENCE_PERMIT_NUMBERVerification commands and results
Environment setup:
Capabilities check:
Scan verification:
Full verification suite:
No other drift found
Verified:
Changelog exemption: Correct internal agent verification instructions; no shipped SDK, runtime or public API changes.