fix(ci): resolve release tag from manifest so CD_production deploys - #759
Merged
Conversation
release-please-action@v5 does not populate a usable `tag_name` output in this manifest setup — it emits `release_created` plus an EMPTY `tag_name` and no path-scoped outputs. The empty tag made CD_production's `startsWith(inputs.tag_name, 'v')` gate silently skip the production deploy (observed on v1.1.1 and v1.1.2, which had to be shipped by re-publishing the release manually). It also handed the forward-merge job an empty tag. Resolve the tag ourselves from the released version in the branch-appropriate manifest (`v<version>`, include-v-in-tag: true), preferring the action's own output if it is ever non-empty. Supersedes PR #756's `.--tag_name` fallback, which targeted a path-scoped output key this configuration never emits. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Document the 2026-07-06 site-wide 500/503 outage: blank-instanceId requests dying in the pending queue, root cause (no max_concurrent_requests vs 4 gunicorn workers → scheduler pins bursts to one instance instead of scaling out), the three-part config fix (max_concurrent_requests: 6, MIN_INSTANCES=1, -w 8), verification, and tuning notes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the broken
tag_namepassthrough inrelease-please.ymlwith a manifest-derived tag resolver, so the production deploy (and forward-merge) actually receive the release tag.Why
release-please-action@v5does not populate a usabletag_nameoutput in this manifest configuration. The action's run log shows it emits exactly two outputs —release_createdand an emptytag_name— and no path-scoped (.--tag_name) outputs exist at all.Consequence:
CD_production's job gatereceives an empty
inputs.tag_name→startsWith('', 'v') = false→ the deploy job silently skips. Observed on both v1.1.1 and v1.1.2 (run 28806722930, 28808275126): the release/tag were created, the reusable workflow was invoked (sorelease_createdpropagated), but the inner job self-skipped. Both releases had to be shipped by manually re-publishing the GitHub release to fire therelease: publishedpath.The
forward-mergejob consumes the sametag_name, so it was getting an empty tag too.Fix
After the release step, resolve the tag from the released version in the branch-appropriate manifest:
MANIFESTfollows the same staging/stable switch already used formanifest-file.release_created == 'true'.Supersedes
PR #756 (already merged) added a
.--tag_namefallback based on a path-scoped output key this configuration never emits — so it had no effect. This PR removes that dead fallback and replaces it with the manifest-derived resolver.Note
This is CI-only. It needs to reach
production(and thus futurehotfix/*branches cut from release tags) via the normal forward-merge flow to fix auto-deploy on those lines.🤖 Generated with Claude Code