chore(ci): track staging for the Dagster+ prod code location - #836
Merged
Conversation
The workflow triggered on `production`, which is still on 1.2.2 and has no automated_ingestion/ directory, so it would never have fired. Every deploy so far has been a branch deployment from a pull request, leaving the prod code location empty -- which is why Dagster+ sits on "waiting for GitHub Actions build to start". "prod" names the Dagster+ deployment, not this repository's production branch. Tracking staging matches how ocotillo-api-staging already behaves and keeps the location current with where the work is. The original reasoning -- that a pipeline writing to the production database should follow the release flow -- still holds, and the comment now says when to act on it: move the trigger back to `production` in the same change that first points the pipeline at the production database. Until then a deploy publishes code and not data, since the location has neither database nor vendor credentials. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Coverage✅ 79.26% total — gate is 75%. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CD_dagster_prod.ymltriggered on pushes toproduction, which is still on1.2.2 and has no
automated_ingestion/directory — so it could never fire.Every deploy so far has been a branch deployment from a pull request, leaving
the Dagster+ prod code location empty. That is why the Dagster+ UI sits on
"Waiting for GitHub Actions build to start".
What changes
One line:
branches: [production]→branches: [staging]."prod" names the Dagster+ deployment, not this repository's
productionbranch. Tracking
stagingmatches howocotillo-api-stagingalready behavesand keeps the code location current with where the work is.
Why not leave it on production
The original reasoning — a pipeline writing to the production database should
follow the release flow — still holds. It is just premature: the pipeline has
no database or vendor credentials yet, so a deploy publishes code, not data,
and the worst it can do is fail to materialize.
The comment now records when to act on it: move the trigger back to
productionin the same change that first points the pipeline at theproduction database. Doing it then keeps the decision attached to the risk
that motivates it.
After merge
The merge itself is a push to
stagingtouching a path in the filter, so itshould deploy the code location on its own.
ingestion_heartbeatis the assetworth materializing to confirm — it touches nothing, so success means the
location loads and runs.
🤖 Generated with Claude Code