Skip to content

chore(ci): track staging for the Dagster+ prod code location - #836

Merged
jirhiker merged 1 commit into
stagingfrom
chore/dagster-prod-tracks-staging
Aug 18, 2026
Merged

chore(ci): track staging for the Dagster+ prod code location#836
jirhiker merged 1 commit into
stagingfrom
chore/dagster-prod-tracks-staging

Conversation

@jirhiker

Copy link
Copy Markdown
Member

CD_dagster_prod.yml triggered on pushes to production, which is still on
1.2.2 and has no automated_ingestion/ directory — so it could never fire.
Every deploy so far has been a branch deployment from a pull request, leaving
the Dagster+ prod code location empty. That is why the Dagster+ UI sits on
"Waiting for GitHub Actions build to start".

What changes

One line: branches: [production]branches: [staging].

"prod" names the Dagster+ deployment, not this repository's production
branch. Tracking staging matches how ocotillo-api-staging already behaves
and keeps the code location current with where the work is.

Why not leave it on production

The original reasoning — a pipeline writing to the production database should
follow the release flow — still holds. It is just premature: the pipeline has
no database or vendor credentials yet, so a deploy publishes code, not data,
and the worst it can do is fail to materialize.

The comment now records when to act on it: move the trigger back to
production in the same change that first points the pipeline at the
production database.
Doing it then keeps the decision attached to the risk
that motivates it.

After merge

The merge itself is a push to staging touching a path in the filter, so it
should deploy the code location on its own. ingestion_heartbeat is the asset
worth materializing to confirm — it touches nothing, so success means the
location loads and runs.

🤖 Generated with Claude Code

The workflow triggered on `production`, which is still on 1.2.2 and has no
automated_ingestion/ directory, so it would never have fired. Every deploy so
far has been a branch deployment from a pull request, leaving the prod code
location empty -- which is why Dagster+ sits on "waiting for GitHub Actions
build to start".

"prod" names the Dagster+ deployment, not this repository's production branch.
Tracking staging matches how ocotillo-api-staging already behaves and keeps the
location current with where the work is.

The original reasoning -- that a pipeline writing to the production database
should follow the release flow -- still holds, and the comment now says when to
act on it: move the trigger back to `production` in the same change that first
points the pipeline at the production database. Until then a deploy publishes
code and not data, since the location has neither database nor vendor
credentials.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@jirhiker
jirhiker merged commit b093232 into staging Aug 18, 2026
9 checks passed
@jirhiker
jirhiker deleted the chore/dagster-prod-tracks-staging branch August 18, 2026 22:29
@github-actions

Copy link
Copy Markdown
Contributor

Coverage

79.26% total — gate is 75%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant