docs(ogc): record the null measuring-point height default - #897
Merged
Conversation
water_well_summary, depth_to_water_trend_wells and water_elevation_wells layers all substitute zero for a missing measuring-point height, treating the measuring point as ground surface. That has been in the SQL since those views were written (COALESCE(measuring_point_height, 0)), but nothing said whether zero was the intended default or an accident. BDMS-974 surfaced the question and deferred it here rather than change the views on a guess. Cris Morton and Ethan Mamer confirmed on 2026-08-26 that zero (ground surface) is the right default, so the views are correct as written and there is no code change to make. What was missing was the record: the next person to read that substitution would ask the same question, and without an answer on file the safe-looking move is to exclude those rows, which would silently drop wells from three published layers. The doc keeps the consequence visible rather than acting on it. Wells with no recorded measuring point are less certain than the rest and nothing in the output says so. Adding a flag column would touch three view definitions and the field descriptions for a subset nobody has sized yet, so the decision records the condition for revisiting it instead. Refs BDMS-980
Contributor
Coverage✅ 79.30% total — gate is 75%. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents how three published OGC layers handle wells with no recorded measuring-point height. Cris Morton and Ethan Mamer confirmed the existing behavior is correct on 2026-08-26, so this is one new doc, no code change.
Why
This PR addresses the following problem / context:
The behavior was already in the SQL but had never been confirmed as intentional. An unwritten answer invites the next reader to "fix" it, which would quietly change what three published layers return.
Changes
Implementation summary - the following was changed / added / removed:
docs/measuring-point-height-null-handling.mdcovering the decision, who made it, and its effect on the affected layers.Notes
Any special considerations, workarounds, or follow-up work to note?