feat(chemistry-well-details): add new items from Mock-up #3 requirements - #1
feat(chemistry-well-details): add new items from Mock-up #3 requirements#1TylerAdamMartinez wants to merge 3 commits into
Conversation
Implemented the following: * Remove the prominent single-event note from the multi-sample view * Keep the sampling-event note as a table column or expandable row detail * Keep parameter notes available for exceptions, such as an ORP measurement that did not stabilize. * Add the Additional Analyses cross-tab. * Update isotope labels to consistent delta notation, including superscript isotope numbers such as δ13C. * Highlight exceeding values in red and bold. * Remove detection limits and errors from the quick display. * Add ion balance as a per-sample General Chemistry column. * Remove ion balance as a note above the table. * Create cross-tab for all views option
|
@TylerAdamMartinez Looks good, there were only two acceptance critieria that I cannot confirm, 1. Inventory legacy chemistry parameters and initially order them by database order - I think this means what you created in the fourth tab, but please confirm. 2. Create cross-tab for all views - specific to parameters tab, but I don't see the difference between this version and the previous one. Thanks! |
|
@lizalino, thanks for reviewing!
Let me know if this matches what you had in mind for those two acceptance criteria. Also, I keep all the information in the "Stabilized" column present in the cross-tabbed version by using the terms "estimated," "stabilized," "clear," and "did not stabilize." I'm not sure those fields are the right terminology; @ksmuczynski, do you have any thoughts about the terms? Also, in the cross-tabbed version, you lose the parameter note, which I don't think is a big issue. |
2 participants
Test this PR by opening the https://raw.githubusercontent.com/DataIntegrationGroup/OcotilloMockups/refs/heads/story/bdms-1053-chemistry-display-mock-3/chemistry-well-details-mockup.html file in your browser.