Fix action/resource on namespace-deactivate and node-copy access checks#2353
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking: #2234 (step 0, action/resource correctness). Route coverage is handled separately in #2334.
Two endpoints have called
AccessChecker.check()since the RBAC engine was wired in (#1579), but with the wrong argument:deactivate_a_namespacerequiredWRITEfor a delete-class operation (it can cascade-delete nodes). ADELETEgrant impliesWRITE, so requiringWRITEis strictly weaker than intended and lets aWRITE-only caller delete. Now requiresDELETE, matching node deactivation and namespace hard-delete.copy_nodepassed the full new node name toadd_namespace, so theWRITEcheck targeted a bogus namespace instead of the new node's parent. Now uses the already-computednew_node_namespace.No-op under the permissive default; only takes effect once a deployment enables restrictive RBAC.
Tests (
tests/api/access_correctness_test.py) fail before and pass after: aWRITE-but-not-DELETEcaller is denied on namespace deactivate, andcopy_nodeauthorizes the parent namespace rather than the full new name.