Add strategy with serializable transaction#132
Open
leoarnold wants to merge 1 commit intoDatabaseCleaner:mainfrom
Open
Add strategy with serializable transaction#132leoarnold wants to merge 1 commit intoDatabaseCleaner:mainfrom
leoarnold wants to merge 1 commit intoDatabaseCleaner:mainfrom
Conversation
Sometimes you need to use a serializable transaction, e.g. to implement a pessimistic "find or create" as explained in [this blog post](https://drmaciver.com/2013/02/implementing-find_or_create-correctly-is-impossible/). In this case, we cannot clean with the Transaction strategy because we cannot nest a serializable transaction into a normal one. We could clean with truncation, but that slows test down dramatically. Starting with Rails v8.1.0, we can nest a transaction into transaction of the same isolation level. This adds a cleaning strategy based on a serializable transaction.
Author
|
Note: The following PRs should be merged for this one to pass CI: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes you need to use a serializable transaction, e.g. to implement a pessimistic "find or create"
as explained in this blog post.
In this case, we cannot clean with the Transaction strategy because we cannot nest a serializable transaction into a normal one.
We could clean with truncation, but that slows test down dramatically.
Starting with Rails v8.1.0, we can nest a transaction into transaction of the same isolation level.
This adds a cleaning strategy based on a serializable transaction.