refactor(architecture): implement 2026-09-18 decisions - #23
Merged
Merged
Conversation
DavidHLP
marked this pull request as ready for review
September 18, 2026 09:35
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the adopted architecture decisions from the 2026-09-18 ResiCache reports:
LoaderOrchestratordoes not report a second time.The report's A3 migration split and A4 annotation re-ownership remain deferred; A5 writer result/statistics module remains closed as YAGNI.
Tickets
Closes #19
Closes #20
Closes #21
Closes #22
Verification
./mvnw -Punit test -B: 718 tests, 0 failures/errors../mvnw clean verify -B: final remote run ended withBUILD SUCCESS,__MAVEN_RC__=0, 914 tests, 0 failures/errors, and all JaCoCo coverage checks met. An earlier non-clean report showed a class/execution-data mismatch and was not used as coverage evidence../mvnw checkstyle:check -B: 0 Checkstyle violations.bash scripts/ci/check-test-names.sh: passed.d989991: 10 checks passed, 0 failed.Checklist
AbstractRedisIntegrationTest(Testcontainers — Docker must be running).bash scripts/ci/check-test-names.shpasses; integration classes do not use*IT.java.Backward compatibility
No public API, new dependency, public executor/event SPI, retry/backoff, metric tag, cache outcome, or serialization protocol change is intended. The A0 change removes redundant internal imports only; A1 is a private helper extraction; A2 documents and tests the existing writer/chain reporter ownership without adding a second reporter path.