refactor(metrics): fold single-consumer timer helper into registry - #29
Merged
Merged
Conversation
DavidHLP
marked this pull request as ready for review
September 19, 2026 05:32
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the scoped C1 architecture recommendation from the supplied 2026-09-19 review: move the single-consumer timer primitives into
RedisProCacheMetricsRegistrywhile preserving the metrics contract.Scope
recordEvictbody-failure coverage for timer and operation-counter finalization;Tracking
Closes #25
Closes #26
Closes #28
Closes #27
Verification
Final PR head:
f245ac86bdd74d4609cbfb97e2ae83e90b010fbd.EXTERNAL_CONSUMER_OK,RM-010 PASS.ci-ok.RedisProCacheTimersreferences remain; stale six-meter wording removed from the changed source/test surfaces.git diff --check: passed.The remote consumer gate used the installed Java 21 path explicitly because the script's default path is not present on
remote-dev; no project source or configuration was changed for that environment detail.