Add native guest ballot creation - #83
Merged
Merged
Conversation
DavidMoritz
approved these changes
Sep 6, 2026
DavidMoritz
left a comment
Owner
There was a problem hiding this comment.
What a clean vertical slice of a feature! The credential handling here is exemplary — immediately destructuring the management token out of displayable state, never logging or sharing it, and the thoughtful recovery path for SecureStore failures. The response validation (including the base64url regex for token format) shows real security consciousness. The UI is accessible, well-tested, and follows all the established patterns perfectly. This whole three-PR stack — from RFC guidance to API to mobile screen — is beautifully structured. We really appreciate all your hard work on this, Emmanuel. It's a joy to review code this thoughtful!
DavidMoritz
force-pushed
the
codex/native-guest-ballot-creation
branch
from
September 6, 2026 23:10
c7845a3 to
4a1f334
Compare
DavidMoritz
force-pushed
the
codex/native-guest-ballot-creation
branch
from
September 6, 2026 23:10
4a1f334 to
1d3732e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Stack
This PR stacks on #81 (guest-ballot API), which stacks on #80 (maintainer guidance/RFC decision).