Repository navigation
chore(config): add devcontainer setup - #154
Draft
etiennej70 wants to merge 3 commits into
Draft
etiennej70 wants to merge 3 commits into
etiennej70 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Shared Docker state, stale PID ownership, and incomplete CA import can cause corruption, unrelated process termination, or failed proxy connectivity.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (6)
Use checkout-specific Docker volume names · New Validate PID ownership before managing stored process groups · New Normalize PEM certificates to CRT before updating trust store · New Capitalize the VS Code product name consistently · New Remove misleading supervisord troubleshooting guidance · New Reference application.yml instead of nonexistent app.yml · New
What changed in this PR
Adds a reproducible VS Code development container with automated services, CI validation, dependency updates, and contributor documentation.
Changes:
- Adds the Java 25 devcontainer and lifecycle scripts.
- Automates PostgreSQL, API, and documentation startup.
- Adds CI verification and weekly dependency updates.
| File | Description |
|---|---|
.devcontainer/Dockerfile |
Builds the development image and imports certificates. |
.devcontainer/certs/.gitkeep |
Preserves the certificate directory. |
.devcontainer/devcontainer-lock.json |
Locks devcontainer features. |
.devcontainer/devcontainer.json |
Configures tools, volumes, ports, and lifecycle commands. |
.devcontainer/post-create.sh |
Installs dependencies and prepares Maven. |
.devcontainer/post-start.sh |
Starts PostgreSQL, docs, and API services. |
.devcontainer/scripts/dev-services.sh |
Manages application and documentation processes. |
.devcontainer/scripts/export-host-ca-certs.sh |
Exports host CA certificates. |
.gitattributes |
Enforces platform-appropriate line endings. |
.github/dependabot.yml |
Adds weekly container dependency updates. |
.github/workflows/devcontainer.yml |
Builds and verifies the devcontainer in CI. |
.gitignore |
Excludes exported host certificates. |
docker-compose.yml |
Pins PostgreSQL and adds a health check. |
docs/src/contributing/development-setup.md |
Documents devcontainer usage and troubleshooting. |
src/main/resources/application-local.yml |
Disables Spring browser LiveReload locally. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| }, | ||
| "mounts": [ | ||
| "source=idp-core-m2,target=/home/vscode/.m2,type=volume", | ||
| "source=idp-core-dind,target=/var/lib/docker,type=volume" |
Comment on lines
+40
to
+41
| pid="$(cat "$IDP_STATE_DIR/$1.pid" 2>/dev/null)" || return 1 | ||
| [ -n "$pid" ] && kill -0 "-$pid" 2>/dev/null && echo "$pid" |
|
|
||
| COPY certs/ /usr/local/share/ca-certificates/idp/ | ||
|
|
||
| RUN update-ca-certificates |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Etienne JACQUOT <2057151+etiennej70@users.noreply.github.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






What this PR Provides
Fixes
N/A
Review
The reviewer must double-check these points:
How to test
Initial state: You have Docker Desktop (Windows/macOS) or Docker Engine (Linux) installed, and VS Code with the "Dev Containers" extension.
Steps:
bash .devcontainer/scripts/dev-services.sh status all— you should see the app and docs services reported as runningExpected result: The container opens without errors, the API and docs are reachable at the URLs above, and code changes trigger an automatic reload.
Breaking changes
N/A