fix(config): idp-core observability by foukou19 · Pull Request #168 · Decathlon/internal-developer-platform

foukou19 · 2026-10-13T13:44:44Z

PR Description

What this PR Provides

Describe in short sentences the goal of the PR. Use lists.
If the PR is linked to an ADR, please provide the link.

Fixes

Review

The reviewer must double-check these points:

The reviewer has tested the feature
The reviewer has reviewed the implementation of the feature
The documentation has been updated
The feature implementation respects the Technical Doc / ADR previously produced
The Pull Request title has a ! after the type/scope to identify the breaking
change in the release note and ensure we will release a major version.

How to test

Please refer (copy/paste) the test section from the User Story. This should include

The initial state: what should be the status of the system before testing
(for example, ensure the data xxx exists in idp-back to be able to test the feature)
What and how to test: steps to perform to test the feature
(for example, go to page xxx, fill the xxx field and click the 'send' button)
Expected results: what should be observed for success or failure
(for example, there is a link in the database between component X and component Y.
You can retrieve the information with a GET request to the API)

Breaking changes (if any)

Data loss / modification
API JSON schema modification (existing resource / behavior)
Behavior modification of a component
Others
N/A

Context of the Breaking Change

For example: we redefined the component types list in the DPAC referential

Result of the Breaking Change

For example: your component of type xxx will migrate to the type yyy

Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com>

Co-authored-by: Eve Bernhard <115796475+evebrnd@users.noreply.github.com> Signed-off-by: ferial OUKOUKAS <75682459+foukou19@users.noreply.github.com>

Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com>

github-code-quality · 2026-10-13T13:52:57Z

Code coverage overview

Languages: Java

Java / code-coverage/jacoco

main 1e7741b	feat/idp-core-observ... 86413c1	+/-
91%	91%	0%

View coverage of the 9 most impacted files.

File	main 1e7741b	feat/idp-core-observ... 86413c1	+/-
`com/decathlon/i...nProcessor.java`	98%	89%	-9%
`com/decathlon/i...yProcessor.java`	100%	98%	-2%
`com/decathlon/i...figuration.java`	0%	0%	0%
`com/decathlon/i...yConstants.java`	0%	0%	0%
`com/decathlon/i...ationUtils.java`	87%	87%	0%
`com/decathlon/i...gProcessor.java`	81%	85%	+4%
`com/decathlon/i...itySupport.java`	0%	88%	+88%
`com/decathlon/i...ebugConfig.java`	0%	92%	+92%
`com/decathlon/i...figuration.java`	0%	100%	+100%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

_{Updated October 19, 2026 15:48 UTC}

Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com>

Signed-off-by: ferial OUKOUKAS <75682459+foukou19@users.noreply.github.com>

Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com> Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com>

Copilot

🟡 Changes recommended

Unresolved metric accuracy and label-cardinality issues undermine reliable monitoring.

5 open findings

What changed in this PR

Adds OpenTelemetry metrics to idp-core’s webhook ingestion pipeline.

Changes:

Instruments security validation, payload decoding, mapping, and entity operations.
Adds shared metric constants, helpers, and meter configuration.
Updates test setup and telemetry dependencies.

File	Description
src/test/java/com/decathlon/idp_core/infrastructure/adapters/ingestion/processor/IngestionProcessorTest.java	Supplies a test meter.
src/test/java/com/decathlon/idp_core/infrastructure/adapters/ingestion/processor/DecodingProcessorTest.java	Updates constructors with a meter.
src/main/java/com/decathlon/idp_core/infrastructure/adapters/ingestion/processor/SecurityProcessor.java	Records security outcomes.
src/main/java/com/decathlon/idp_core/infrastructure/adapters/ingestion/processor/IngestionProcessor.java	Records mapping and entity metrics.
src/main/java/com/decathlon/idp_core/infrastructure/adapters/ingestion/processor/decoder/DecodingProcessor.java	Records decoding outcomes and payload sizes.
src/main/java/com/decathlon/idp_core/infrastructure/adapters/ingestion/metrics/IngestionObservabilitySupport.java	Adds shared instrumentation helpers.
src/main/java/com/decathlon/idp_core/infrastructure/adapters/ingestion/configuration/IngestionObservabilityConstants.java	Defines metric names and attributes.
src/main/java/com/decathlon/idp_core/infrastructure/adapters/ingestion/configuration/IngestionMetricsConfiguration.java	Configures scoped meters.
pom.xml	Adds telemetry API and testing dependencies.

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+      incrementCounter(IngestionObservabilityConstants.FUNCTIONAL_VALIDATION_FAILED_TOTAL,
+          ATTRIBUTE_CONNECTOR, connectorIdentifier, "mapping_id", mappingId,
+          ATTRIBUTE_REASON, exception.getClass().getSimpleName());
+      recordEntityFailureMetrics(connectorIdentifier, exception);


+    incrementCounter(IngestionObservabilityConstants.ENTITY_VALIDATION_ERRORS_TOTAL,
+        ATTRIBUTE_TEMPLATE, templateIdentifier, ATTRIBUTE_CONNECTOR, connectorIdentifier,
+        ATTRIBUTE_REASON, exception.getClass().getSimpleName());


+    String connector = headers == null
+        ? "unknown"
+        : String.valueOf(headers.getOrDefault("connector", "unknown"));


+      if (!(exception instanceof WebhookDecodingException)) {
+        incrementDecodeErrorMetric(connector, exception.getClass().getSimpleName());
+      }


-      return new String(decodedPayload, StandardCharsets.UTF_8);
+      String result = new String(decodedPayload, StandardCharsets.UTF_8);
+      recordPayloadSizeMetric(connector, decodedPayload.length);
+      incrementDecodedMetric(connector, String.join(",", encodingChain));


Copilot

🟡 Changes recommended

The new OpenTelemetry meters are not connected to the configured metrics export path.

6 open findings

🧠 Review effort: Balanced

+  public Meter ingestionMeter(OpenTelemetry openTelemetry) {
+    return openTelemetry.getMeterProvider().meterBuilder("com.decathlon.idp_core.ingestion")
+        .build();


Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com>

sonarqubecloud · 2026-10-19T15:48:15Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
81.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

foukou19 and others added 10 commits October 6, 2026 11:32

feat(config): update OpenTelemetry OTLP

b98b630

Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com>

feat(config): Adapt webhooks security configuration

76f3ec9

Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com>

fix: resolution conflit sur webhooks.md

bf81dd8

feat(config): update webhook.md

e46ae70

Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com>

Merge branch 'main' into feat/idp-core-observability-otel-starter

4ee4d47

feat(config): update application.yaml

bb69f19

Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com>

Update docs/src/features/webhooks.md

6a1d961

Co-authored-by: Eve Bernhard <115796475+evebrnd@users.noreply.github.com> Signed-off-by: ferial OUKOUKAS <75682459+foukou19@users.noreply.github.com>

feat(config): update application.yaml

fee9111

Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com>

feat(config): update application.yaml

92d43ba

Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com>

feat(observability): add custom webhook security metrics

5924d23

Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com>

foukou19 changed the title ~~Feat/idp core observability~~ feat(config): idp-core observability Oct 13, 2026

feat(observability): add custom webhook security metrics

4bad155

Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com>

foukou19 force-pushed the feat/idp-core-observability branch from 3229034 to 4bad155 Compare October 13, 2026 13:48

foukou19 and others added 4 commits October 14, 2026 16:55

feat(config): add custom webhook ingestion metrics

a598f66

Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com>

Merge branch 'main' into feat/idp-core-observability

4f91fed

Signed-off-by: ferial OUKOUKAS <75682459+foukou19@users.noreply.github.com>

feat(config): centralize webhook metrics and tracing

ad98b66

Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com> Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com>

Merge branch 'main' into feat/idp-core-observability

372e20f

foukou19 requested a balanced review from Copilot October 16, 2026 05:52

Copilot started reviewing on behalf of foukou19 October 16, 2026 05:53

View session

Copilot AI reviewed Oct 16, 2026

View reviewed changes

foukou19 requested a balanced review from Copilot October 16, 2026 07:02

Copilot started reviewing on behalf of foukou19 October 16, 2026 07:03

View session

Copilot AI reviewed Oct 16, 2026

View reviewed changes

foukou19 force-pushed the feat/idp-core-observability branch 4 times, most recently from 072443b to 33e8861 Compare October 16, 2026 10:04

feat(config): centralize webhook metrics and tracing

d55eb94

Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com>

foukou19 force-pushed the feat/idp-core-observability branch from 33e8861 to d55eb94 Compare October 16, 2026 13:51

foukou19 force-pushed the feat/idp-core-observability branch 4 times, most recently from 5178c90 to 7b0813f Compare October 16, 2026 18:42

feat(config): update webhook metrics

7d67e93

Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com>

foukou19 force-pushed the feat/idp-core-observability branch from 7b0813f to 7d67e93 Compare October 16, 2026 19:40

feat(config): update camel tracing configuration

ec92e1d

Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com>

foukou19 force-pushed the feat/idp-core-observability branch from 3da9835 to 1bed986 Compare October 19, 2026 15:02

feat(config): update CamelTracingConfiguration

86413c1

Signed-off-by: foukou19 <ferial.oukoukas@decathlon.com>

foukou19 force-pushed the feat/idp-core-observability branch from 1bed986 to 86413c1 Compare October 19, 2026 15:34

foukou19 changed the title ~~feat(config): idp-core observability~~ fix(config): idp-core observability Oct 19, 2026

Navigation Menu

Repository navigation

fix(config): idp-core observability - #168

fix(config): idp-core observability#168
foukou19 wants to merge 19 commits into
mainfrom
feat/idp-core-observability

foukou19 commented Oct 13, 2026

Uh oh!

github-code-quality Bot commented Oct 13, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

sonarqubecloud Bot commented Oct 19, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

foukou19 commented Oct 13, 2026

PR Description

What this PR Provides

Fixes

Review

How to test

Breaking changes (if any)

Context of the Breaking Change

Result of the Breaking Change

Uh oh!

github-code-quality Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code coverage overview

Java / code-coverage/jacoco

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

sonarqubecloud Bot commented Oct 19, 2026

Quality Gate passed

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-code-quality Bot commented Oct 13, 2026 •

edited

Loading