Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe GitLab CI configuration retains ChangesGitLab CI test configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The configuration keeps PHPUnit options separate from 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.1.x #35 +/- ##
=======================================
Coverage 78.58% 78.58%
=======================================
Files 25 25
Lines 1723 1723
Branches 64 64
=======================================
Hits 1354 1354
Misses 366 366
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Problem
gitlab_templates 1.17.0 made
_PHPUNIT_CONCURRENT: 1the default on Drupal.org. The phpunit job now runs core'srun-tests.shinstead of the phpunit binary.When
_RUNTESTS_EXTRAis blank, the template copies_PHPUNIT_EXTRAinto it. Our--configuration=phpunit.gitlab-ci.xmlbecomes a relative--phpunit-configuration.run-tests.shchanges toweb/first, so the file is not found and the job stops before any test runs.Change
_PHPUNIT_EXTRA. The phpunit binary (_PHPUNIT_CONCURRENT: 0) loadsphpunit.xmlfrom the project root. That file is the scaffold config for local and GitHub runs. The flag points the binary at the DrupalCI config instead._RUNTESTS_EXTRA: '-'. The-stops the copy.run-tests.shthen uses core'sphpunit.xml.dist, which is its default on both 11.4 and 10.6.GitHub Actions does not read
.gitlab-ci.ymlorphpunit.gitlab-ci.xml. This PR confirms nothing here changes for it.Same change as jsonapi_menu_items, tracked in https://git.drupalcode.org/project/jsonapi_menu_items/-/work_items/3591567.
Summary by CodeRabbit