Repository navigation
Conversation
C-Achard
added this pull request to stack #52
October 14, 2026 08:22
Add a local pre-commit hook that validates every file covered by `NOTICE.yml` has the expected license header. The new `tools/check_license_headers.py` script reuses the existing NOTICE traversal logic, reports files with missing or outdated headers, and keeps the check read-only so header updates still go through the dedicated update script.
C-Achard
force-pushed
the
cy/license-header-check
branch
from
October 14, 2026 08:36
45b5b72 to
2ff371c
Compare
C-Achard
requested review from
AlexEMG,
MMathisLab and
deruyter92
and
a balanced review from Copilot
October 14, 2026 08:54
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The validator and hook integration are consistent with the existing header updater and CI workflow.
0 open findings
What changed in this PR
Adds a read-only license-header validator and integrates it into pre-commit workflows.
Changes:
- Validates all files covered by
NOTICE.yml. - Runs validation during pre-commit and manual CI stages.
| File | Description |
|---|---|
tools/check_license_headers.py |
Implements license-header validation. |
.pre-commit-config.yaml |
Registers the validation hook. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a check/write split; important for upcoming additions as they have no header yet.