Unset config-env-vars and config-vars-init-random#46
Conversation
Unset specific input variables in the action script.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe composite action exports ChangesEnvironment variable cleanup before command execution
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@action.yaml`:
- Around line 187-188: The unset invocation using the expanded inputs ('${{
inputs['config-env-vars'] }}' and '${{ inputs['config-vars-init-random'] }}') is
unsafe for newline-delimited values and will break if inputs contain embedded
newlines; replace the single unsafe unset call with a loop that iterates over
each variable name (split on newlines) and calls unset on each item individually
(e.g., read the inputs into lines and for each line run unset "$var"), ensuring
you still unset the literal dont_complain_on_empty as well; update the code
around the unset statement to perform per-line safe unsets for the two input
variables referenced.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Unset specific input variables in the action script.
Summary by CodeRabbit