feat(templates): stop claiming runtime modules as CV meanings - #595
Open
DemchaAV wants to merge 2 commits into
Open
feat(templates): stop claiming runtime modules as CV meanings#595DemchaAV wants to merge 2 commits into
DemchaAV wants to merge 2 commits into
Conversation
A ModuleSection is a shape. SectionRouter.find and SectionAllocation.claim no longer take one: slots still match typed sections by heading, and modules stay in document order or the leftover tail and draw through CvConstructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#594 made templates implement module kinds. Slots still asked
SectionRolefirst, so a runtime module titledОпыт работыwas treated as Experience. That is the axis the constructor is not: the template does not know Experience from Projects.What changed
SectionRouter.findandSectionAllocation.claimnever take aModuleSection. Typed sections still match by heading.remaining(), and draws throughCvConstructor/ leftover renderers.RoleRoutingTestnow runs onCvTemplates.modular()and asserts the words reach the page, not that a role named a slot.asEntries/asRows/asSkills/asParagraphdirectly — that is still how a leftover takes a preset's existing renderer.SectionRoleis still onModuleSectionso existing builders compile; dropping it from the public constructor payload is the next PR.Verification
./mvnw -B -ntp -pl :graph-compose-templates test→ BUILD SUCCESS, 143 tests../mvnw -B -ntp -pl :graph-compose-templates,:graph-compose-qa -am test -Dtest=ModularCvTemplateFidelityTest,RoleRoutingTest,SectionAllocationTest,LeftoverSectionTest,SlotHeadingFidelityTest,SectionRouterTest→ BUILD SUCCESS, 121 tests in qa, 0 failures.Lane: templates — constructor placement.
Stacked on #594 (
feat/cv-constructor-kinds). Next: dropSectionRolefromModuleSection.