Skip to content

Depend on detsys-ts from npm - #312

Merged
grahamc merged 1 commit into
mainfrom
grahamc/detsys-ts-from-npm
Sep 2, 2026
Merged

Depend on detsys-ts from npm#312
grahamc merged 1 commit into
mainfrom
grahamc/detsys-ts-from-npm

Conversation

@grahamc

@grahamc grahamc commented Sep 2, 2026

Copy link
Copy Markdown
Member

The library is published as @determinate-systems/detsys-ts. Use the 1.x release line from the registry instead of a git reference.

Description
Checklist
  • Tested functionality against a test repository (see "How to test changes")
  • Added or updated relevant documentation (leave unchecked if not applicable)

Summary by CodeRabbit

  • Chores
    • Updated the application to use the published Determinate Systems package.
    • No user-facing functionality changes.

The library is published as @determinate-systems/detsys-ts.
Use the 1.x release line from the registry instead of a git reference.
@grahamc
grahamc marked this pull request as ready for review September 2, 2026 21:53
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Essentials

Run ID: 2488ebab-f93e-4b0c-b48a-aaf6a080faf8

📥 Commits

Reviewing files that changed from the base of the PR and between f21d5f4 and 66d249d.

⛔ Files ignored due to path filters (3)
  • dist/index.js is excluded by !**/dist/**
  • dist/index.js.map is excluded by !**/dist/**, !**/*.map
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json
  • src/index.ts

Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The project replaces the GitHub-based detsys-ts dependency with the published @determinate-systems/detsys-ts package and updates the corresponding import.

Changes

DetSys package migration

Layer / File(s) Summary
Published package dependency wiring
package.json, src/index.ts
package.json now uses @determinate-systems/detsys-ts at ^1.0.0. src/index.ts imports DetSysAction and inputs from the scoped package.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 66d24

This changes the dependency from a Git reference to the published npm 1.x release line and updates the associated generated files. No actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: lucperkins

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: replacing the Git reference with the published detsys-ts npm package.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch grahamc/detsys-ts-from-npm

Comment @coderabbitai help to get the list of available commands.

@grahamc
grahamc merged commit 0146715 into main Sep 2, 2026
5 checks passed
@grahamc
grahamc deleted the grahamc/detsys-ts-from-npm branch September 2, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants