Conversation
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
Fixes DeusData#1642 Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
mvanhorn
force-pushed
the
fix/1642-codebase-memory-mcp-reference-classification
branch
from
September 16, 2026 15:11
17a326a to
43620d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update
FilterPanel.tsxso the section is titled "Reference coverage", the candidate count reads "N with no known inbound references", and the existing filter reads "Show only nodes with no known inbound references". Add a short explanation in that section: "No known inbound references does not prove code is unused. Static analysis may miss constructors, implicit or framework calls, and callbacks." Change thedeadentry inSTATUS_LEGENDincolors.tsto "No known inbound references", and clarify the nearby status comment while retaining its existing key and color.The graph UI presents functions and methods with no known incoming CALLS, USAGE, or CALL_REFERENCE edges as definitively dead, even though constructors, runtime/framework dispatch, and callbacks can execute without those edges being extracted. The reporter found 50 false positives in 50 sampled nodes, and another user reproduced the constructor case on v0.10.8. Owner DeusData explicitly requested that the first fix remove false certainty at the presentation boundary and leave extraction improvements to separate graph-quality work. This plan implements that first step and should reference the issue with
Refs #1642, rather than claiming to repair missing graph edges or close the entire report.Fixes #1642
Checklist
git commit -s) — required, CI rejectsNot run: no test command resolved in this workspace, so nothing was executed to pass.
unsigned commits (DCO, see CONTRIBUTING.md)
make -f Makefile.cbm test)Not run: no test command resolved in this workspace, so nothing was executed to pass.
make -f Makefile.cbm lint-ci)Not run: no test command resolved in this workspace, so nothing was executed to pass.