Fix missing Clerk auth UI on sign-in and sign-up#77
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause:
This issue was primarily CSP, not Clerk path routing. The live production SignUp page loaded Clerk from the custom Frontend API origin https://clerk.callbackcloser.com, but our production CSP only allowed https://.clerk.com and https://.clerk.accounts.dev. The browser blocked clerk.browser.js, so the page shell rendered but the right-side Clerk SignUp/SignIn UI stayed blank.
Secondary path/routing hardening:
The auth pages were also passing env-normalized Clerk URLs into the widget path props. That was not the production blank-state root cause, but the page now uses stable base paths (/sign-up and /sign-in) for Clerk routing and strips query params from env-derived auth URLs to avoid future path mismatches.
What changed:
Validation:
Manual incognito QA results:
Notes: