Build safe public simulator demo#79
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The old public simulator looked broken because it exposed setup-dependent messaging and felt unfinished. The first pass fixed the safety and interaction model; this cleanup pass makes the sales flow clearer, removes the favicon noise, and leaves the remaining localhost Clerk issue clearly documented instead of hidden.
Safety confirmation
Validation
npx tsx --test tests/public-demo-route.test.ts tests/public-simulator-flow.test.ts tests/simulator-isolation.test.ts tests/simulator-route.test.ts tests/favicon-route.test.tsnpm run typechecknpm run lintnpm run testnpm run build/simulator, completed a run with quick + typed replies, confirmed owner alert preview, reset/replay, mobile layout, and favicon behaviorRemaining known issues
.env.exampleandREADME.md