Repository navigation
CI: type-check Jest test files in __internal - #33950
Merged
aleksei-semikozov merged 1 commit intoJun 17, 2026
Merged
Conversation
aleksei-semikozov
force-pushed
the
ci-check-test-types
branch
3 times, most recently
from
June 11, 2026 16:14
64602aa to
ae92abf
Compare
aleksei-semikozov
marked this pull request as ready for review
June 11, 2026 18:23
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated Nx target to TypeScript type-check Jest tests under packages/devextreme/js/__internal and wires it into the Renovation CI workflow to fail fast on type errors.
Changes:
- Added a
check-typesnpm script that runstsc --noEmitagainstjs/__internal/tsconfig.json. - Added an Nx
check-typestarget for thedevextremeproject (usingnx:run-script). - Updated the Renovation GitHub Actions workflow to run
nx check-types devextremebefore Jest.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/project.json | Introduces check-types Nx target and caching inputs for the type-check step. |
| packages/devextreme/package.json | Adds check-types script invoking tsc --noEmit for js/__internal. |
| .github/workflows/renovation.yml | Runs the new type-check step in CI prior to executing Jest tests. |
aleksei-semikozov
force-pushed
the
ci-check-test-types
branch
from
June 12, 2026 10:13
ae92abf to
ecab259
Compare
aleksei-semikozov
force-pushed
the
ci-check-test-types
branch
from
June 12, 2026 10:21
ecab259 to
2f5d983
Compare
aleksei-semikozov
force-pushed
the
ci-check-test-types
branch
from
June 12, 2026 12:24
2f5d983 to
34e1898
Compare
aleksei-semikozov
force-pushed
the
ci-check-test-types
branch
from
June 12, 2026 12:50
34e1898 to
22b84cb
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/jest_tests.yml:56
nx check-types devextremewill fail because thedevextremeproject does not define acheck-typesNx target (packages/devextreme/project.json has targets liketest-jest, but nocheck-types). Either add the Nx target or invoke the new package script directly frompackages/devextreme.
aleksei-semikozov
force-pushed
the
ci-check-test-types
branch
from
June 15, 2026 08:49
22b84cb to
a069347
Compare
IlyaKhD
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.